Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ruben Van Boxem <vanboxem.ruben@gmail.com>
To: gdb-patches@sourceware.org,
		mingw64 <mingw-w64-public@lists.sourceforge.net>
Subject: [PATCH] 64-bit python support
Date: Tue, 10 May 2011 12:57:00 -0000	[thread overview]
Message-ID: <BANLkTi=2gphWs2p_5V+wTJMUAkjHDT79uQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Hi,

Attached is a patch that tells gdb-python to use the Py_InitModule4_64
function instead of Py_InitModule for 64-bit builds.

The latter is not in the official Python x64 Windows dll, and from
looking around on the net, neither is it present on 64-bit linux
Python libraries (can't say that for sure though). This patch allows a
successful build with mingw-w64.

Here is a link to the rationale for the different function name on the
Python website:
http://www.python.org/dev/peps/pep-0353/#specification

The patch was made using the 7.3 branch. Please comment on and/or OK
this patch. Thanks!

Ruben

[-- Attachment #2: gdb-python64.patch --]
[-- Type: text/x-patch, Size: 1014 bytes --]

diff --git a/gdb/python/py-evts.c b/gdb/python/py-evts.c
index 50c05f3..3a541b4 100644
--- a/gdb/python/py-evts.c
+++ b/gdb/python/py-evts.c
@@ -44,8 +44,11 @@ add_new_registry (eventregistry_object **registryp, char *name)
 void
 gdbpy_initialize_py_events (void)
 {
+#if defined(__x86_64__)
+  gdb_py_events.module = Py_InitModule4_64 ("events", NULL);
+#else
   gdb_py_events.module = Py_InitModule ("events", NULL);
-
+#endif
   if (!gdb_py_events.module)
     goto fail;
 
diff --git a/gdb/python/python.c b/gdb/python/python.c
index 90d5dc8..3323433 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1013,7 +1013,11 @@ Enables or disables printing of Python stack traces."),
   Py_Initialize ();
   PyEval_InitThreads ();
 
+#if defined(__x86_64__)
+  gdb_module = Py_InitModule4_64 ("gdb", GdbMethods);
+#else
   gdb_module = Py_InitModule ("gdb", GdbMethods);
+#endif
 
   /* The casts to (char*) are for python 2.4.  */
   PyModule_AddStringConstant (gdb_module, "VERSION", (char*) version);

             reply	other threads:[~2011-05-10 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 12:57 Ruben Van Boxem [this message]
     [not found] <BANLkTi=2gphWs2p_5V+wTJMUAkjHDT79uQ__10646.2358417504$1305032253$gmane$org@mail.gmail.com>
2011-05-10 14:29 ` Tom Tromey
2011-05-10 14:32   ` Ruben Van Boxem
     [not found]   ` <BANLkTikrs+AFqqiQEwQfmD=c3wicjSdWYA__43532.2708603509$1305037944$gmane$org@mail.gmail.com>
2011-05-10 14:38     ` Tom Tromey
2011-05-10 15:03       ` Ruben Van Boxem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=2gphWs2p_5V+wTJMUAkjHDT79uQ@mail.gmail.com' \
    --to=vanboxem.ruben@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mingw-w64-public@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox