From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Hui Zhu <teawater@gmail.com>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [OB] Fix build error in ui-file.c
Date: Mon, 16 May 2011 18:26:00 -0000 [thread overview]
Message-ID: <BANLkTikJUjqpeGUNmF63G0jCQqeAq6UbiQ@mail.gmail.com> (raw)
In-Reply-To: <m3r57yhbn7.fsf@fleche.redhat.com>
On Mon, May 16, 2011 at 9:07 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> What about add comments like other functions in this file?
>
> It seems like a good idea, if you are so inclined.
>
> Tom
>
I wouldn't mind comments to the other invocations either.
http://sourceware.org/ml/gdb-patches/2011-05/msg00335.html
prev parent reply other threads:[~2011-05-16 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 3:41 Hui Zhu
2011-05-14 17:12 ` Joel Brobecker
2011-05-15 2:59 ` Hui Zhu
2011-05-16 16:08 ` Tom Tromey
2011-05-16 18:26 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikJUjqpeGUNmF63G0jCQqeAq6UbiQ@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox