From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19964 invoked by alias); 16 May 2011 18:26:48 -0000 Received: (qmail 19956 invoked by uid 22791); 16 May 2011 18:26:47 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 May 2011 18:26:33 +0000 Received: from kpbe11.cbf.corp.google.com (kpbe11.cbf.corp.google.com [172.25.105.75]) by smtp-out.google.com with ESMTP id p4GIQVvu026719 for ; Mon, 16 May 2011 11:26:31 -0700 Received: from gwj17 (gwj17.prod.google.com [10.200.10.17]) by kpbe11.cbf.corp.google.com with ESMTP id p4GIPaTN023129 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 16 May 2011 11:26:30 -0700 Received: by gwj17 with SMTP id 17so1829388gwj.38 for ; Mon, 16 May 2011 11:26:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.91.198.23 with SMTP id a23mr3617447agq.45.1305570389506; Mon, 16 May 2011 11:26:29 -0700 (PDT) Received: by 10.90.72.6 with HTTP; Mon, 16 May 2011 11:26:29 -0700 (PDT) In-Reply-To: References: <20110514171204.GE19356@adacore.com> Date: Mon, 16 May 2011 18:26:00 -0000 Message-ID: Subject: Re: [OB] Fix build error in ui-file.c From: Doug Evans To: Tom Tromey Cc: Hui Zhu , Joel Brobecker , gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00366.txt.bz2 On Mon, May 16, 2011 at 9:07 AM, Tom Tromey wrote: >>>>>> ">" == Hui Zhu writes: > >>> What about add comments like other functions in this file? > > It seems like a good idea, if you are so inclined. > > Tom > I wouldn't mind comments to the other invocations either. http://sourceware.org/ml/gdb-patches/2011-05/msg00335.html