From: Ian Lance Taylor <iant@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, gdb-patches@sourceware.org
Subject: Re: [gcc patch 1/3] cp-demangle.c: Make `options' a parameter
Date: Mon, 13 Jun 2011 18:06:00 -0000 [thread overview]
Message-ID: <BANLkTi=4Z48GFiZuVM9mvn9vYNY2sYY6qw@mail.gmail.com> (raw)
In-Reply-To: <20110602141532.GB15093@host1.jankratochvil.net>
On Thu, Jun 2, 2011 at 7:15 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
>
> libiberty/
> 2011-05-24 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * cp-demangle.c (struct d_print_info): Remove field options.
> (d_print_init): Remove parameter options.
> (cplus_demangle_print_callback): Update all the callers.
> (d_print_comp, d_print_mod_list, d_print_mod, d_print_function_type)
> (d_print_array_type, d_print_expr_op, d_print_cast, d_print_subexpr):
> Add parameter options, update all the callers.
> static void
> -d_print_comp (struct d_print_info *, const struct demangle_component *);
> +d_print_comp (struct d_print_info *, const struct demangle_component *, int);
The new options parameter should be the second parameter, not the last.
> static void
> -d_print_mod_list (struct d_print_info *, struct d_print_mod *, int);
> +d_print_mod_list (struct d_print_info *, struct d_print_mod *, int, int);
Likewise.
> static void
> -d_print_mod (struct d_print_info *, const struct demangle_component *);
> +d_print_mod (struct d_print_info *, const struct demangle_component *, int);
Likewise.
> static void
> d_print_function_type (struct d_print_info *,
> const struct demangle_component *,
> - struct d_print_mod *);
> + struct d_print_mod *, int);
Likewise.
> static void
> d_print_array_type (struct d_print_info *,
> const struct demangle_component *,
> - struct d_print_mod *);
> + struct d_print_mod *, int);
Likewise.
> static void
> -d_print_expr_op (struct d_print_info *, const struct demangle_component *);
> +d_print_expr_op (struct d_print_info *, const struct demangle_component *, int);
Likewise.
> static void
> -d_print_cast (struct d_print_info *, const struct demangle_component *);
> +d_print_cast (struct d_print_info *, const struct demangle_component *, int);
Likewise.
You will have to change the function definitions and calls accordingly.
This is OK with those changes.
Thanks.
Ian
next prev parent reply other threads:[~2011-06-13 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 14:16 Jan Kratochvil
2011-06-13 18:06 ` Ian Lance Taylor [this message]
2011-06-13 22:37 ` Jan Kratochvil
[not found] ` <20110613223626.GA31462__41741.6748627604$1308004649$gmane$org@host1.jankratochvil.net>
2011-06-14 16:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=4Z48GFiZuVM9mvn9vYNY2sYY6qw@mail.gmail.com' \
--to=iant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox