From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29030 invoked by alias); 13 Jun 2011 18:06:46 -0000 Received: (qmail 29022 invoked by uid 22791); 13 Jun 2011 18:06:46 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Jun 2011 18:06:25 +0000 Received: from wpaz13.hot.corp.google.com (wpaz13.hot.corp.google.com [172.24.198.77]) by smtp-out.google.com with ESMTP id p5DI6NPe030404 for ; Mon, 13 Jun 2011 11:06:24 -0700 Received: from yia13 (yia13.prod.google.com [10.243.65.13]) by wpaz13.hot.corp.google.com with ESMTP id p5DI6Mix025674 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 13 Jun 2011 11:06:22 -0700 Received: by yia13 with SMTP id 13so2240609yia.28 for ; Mon, 13 Jun 2011 11:06:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.72.23 with SMTP id u23mr7111185yba.160.1307988381855; Mon, 13 Jun 2011 11:06:21 -0700 (PDT) Received: by 10.151.39.12 with HTTP; Mon, 13 Jun 2011 11:06:21 -0700 (PDT) In-Reply-To: <20110602141532.GB15093@host1.jankratochvil.net> References: <20110602141532.GB15093@host1.jankratochvil.net> Date: Mon, 13 Jun 2011 18:06:00 -0000 Message-ID: Subject: Re: [gcc patch 1/3] cp-demangle.c: Make `options' a parameter From: Ian Lance Taylor To: Jan Kratochvil Cc: gcc-patches , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00173.txt.bz2 On Thu, Jun 2, 2011 at 7:15 AM, Jan Kratochvil wrote: > > libiberty/ > 2011-05-24 =A0Jan Kratochvil =A0 > > =A0 =A0 =A0 =A0* cp-demangle.c (struct d_print_info): Remove field option= s. > =A0 =A0 =A0 =A0(d_print_init): Remove parameter options. > =A0 =A0 =A0 =A0(cplus_demangle_print_callback): Update all the callers. > =A0 =A0 =A0 =A0(d_print_comp, d_print_mod_list, d_print_mod, d_print_func= tion_type) > =A0 =A0 =A0 =A0(d_print_array_type, d_print_expr_op, d_print_cast, d_prin= t_subexpr): > =A0 =A0 =A0 =A0Add parameter options, update all the callers. > =A0static void > -d_print_comp (struct d_print_info *, const struct demangle_component *); > +d_print_comp (struct d_print_info *, const struct demangle_component *, = int); The new options parameter should be the second parameter, not the last. > =A0static void > -d_print_mod_list (struct d_print_info *, struct d_print_mod *, int); > +d_print_mod_list (struct d_print_info *, struct d_print_mod *, int, int); Likewise. > =A0static void > -d_print_mod (struct d_print_info *, const struct demangle_component *); > +d_print_mod (struct d_print_info *, const struct demangle_component *, i= nt); Likewise. > =A0static void > =A0d_print_function_type (struct d_print_info *, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0const struct demangle_comp= onent *, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct d_print_mod *); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct d_print_mod *, int); Likewise. > =A0static void > =A0d_print_array_type (struct d_print_info *, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const struct demangle_component *, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct d_print_mod *); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct d_print_mod *, int); Likewise. > =A0static void > -d_print_expr_op (struct d_print_info *, const struct demangle_component = *); > +d_print_expr_op (struct d_print_info *, const struct demangle_component = *, int); Likewise. > =A0static void > -d_print_cast (struct d_print_info *, const struct demangle_component *); > +d_print_cast (struct d_print_info *, const struct demangle_component *, = int); Likewise. You will have to change the function definitions and calls accordingly. This is OK with those changes. Thanks. Ian