From: Tristan Gingold <gingold@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression on prelinked-sepdebug-shlibs
Date: Wed, 06 Jan 2010 16:38:00 -0000 [thread overview]
Message-ID: <B936F89D-B788-405A-B9AD-27A0E50206DD@adacore.com> (raw)
In-Reply-To: <20091225200440.GA3747@host0.dyn.jankratochvil.net>
Jan,
do you have a patch for dwarf2read.c(dwarf2_psymtab_to_symtab) ?
/* If this psymtab is constructed from a debug-only objfile, the
has_section_at_zero flag will not necessarily be correct. We
can get the correct value for this flag by looking at the data
associated with the (presumably stripped) associated objfile. */
if (pst->objfile->separate_debug_objfile_backlink)
{
struct dwarf2_per_objfile *dpo_backlink
= objfile_data (pst->objfile->separate_debug_objfile_backlink,
dwarf2_objfile_data_key);
dwarf2_per_objfile->has_section_at_zero
= dpo_backlink->has_section_at_zero;
}
I think this is not correct: the separate debug file may have one section at zero while the main may not.
In the above code, we do not consider wether an offset is used.
I am not sure that this can happen with ELF however.
Tristan.
next prev parent reply other threads:[~2010-01-06 16:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-25 20:05 Jan Kratochvil
2010-01-04 9:50 ` Tristan Gingold
2010-01-04 10:24 ` Jan Kratochvil
2010-01-04 11:54 ` Tristan Gingold
2010-01-04 15:22 ` Tristan Gingold
2010-01-04 18:10 ` Jan Kratochvil
2010-01-05 11:02 ` Tristan Gingold
2010-01-05 16:15 ` Jan Kratochvil
2010-01-06 11:20 ` Tristan Gingold
2010-01-06 16:38 ` Tristan Gingold [this message]
2010-01-06 18:05 ` Jan Kratochvil
2010-01-06 19:16 ` Daniel Jacobowitz
2010-01-07 11:02 ` Tristan Gingold
2010-01-07 11:10 ` Jan Kratochvil
2010-01-07 11:18 ` Tristan Gingold
2010-01-07 13:42 ` Daniel Jacobowitz
2010-01-07 14:21 ` Tristan Gingold
2010-01-07 14:26 ` Daniel Jacobowitz
2010-01-07 14:37 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B936F89D-B788-405A-B9AD-27A0E50206DD@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox