Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression on prelinked-sepdebug-shlibs
Date: Mon, 04 Jan 2010 18:10:00 -0000	[thread overview]
Message-ID: <20100104181009.GA15630@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <1EA52AF6-6633-4D00-A3D7-842856D6C908@adacore.com>

Hi Tristan,

On Mon, 04 Jan 2010 16:23:22 +0100, Tristan Gingold wrote:
> can you try and/or comment this patch before I officially submit it ?  No sepdebug.exp regressions.

it works (for the reproducer I provided - you could not run it?) after
removing:

+  /* In most cases, the offsets are 0.  In this case we return NULL to reduce
+     overhead.  */
+  for (i = 0; i < objfile->num_sections; i++)
+    if (objfile->section_offsets->offsets[i])
+      break;
+  if (i >= objfile->num_sections)
+    return NULL;

These offsets are for file vs. memory displacement.  If I have .so prelinked at
0x3404200190 it gets loaded at 0x3404200190 so
objfile->section_offsets->offsets[*] will be 0 but still the .so.debug file is
0x0-based and the .so.debug file needs to be relocated to 0x3404200190.


Thanks,
Jan


  reply	other threads:[~2010-01-04 18:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-25 20:05 Jan Kratochvil
2010-01-04  9:50 ` Tristan Gingold
2010-01-04 10:24   ` Jan Kratochvil
2010-01-04 11:54     ` Tristan Gingold
2010-01-04 15:22 ` Tristan Gingold
2010-01-04 18:10   ` Jan Kratochvil [this message]
2010-01-05 11:02     ` Tristan Gingold
2010-01-05 16:15       ` Jan Kratochvil
2010-01-06 11:20         ` Tristan Gingold
2010-01-06 16:38 ` Tristan Gingold
2010-01-06 18:05   ` Jan Kratochvil
2010-01-06 19:16     ` Daniel Jacobowitz
2010-01-07 11:02       ` Tristan Gingold
2010-01-07 11:10         ` Jan Kratochvil
2010-01-07 11:18           ` Tristan Gingold
2010-01-07 13:42         ` Daniel Jacobowitz
2010-01-07 14:21           ` Tristan Gingold
2010-01-07 14:26             ` Daniel Jacobowitz
2010-01-07 14:37               ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100104181009.GA15630@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox