From: Mike Stump <mikestump@comcast.net>
To: gdb-patches@sourceware.org
Subject: simple typo with cache_ovly_table
Date: Wed, 21 Oct 2015 19:47:00 -0000 [thread overview]
Message-ID: <B2B5BD3D-8DF9-46EF-B3BF-4C2147528948@comcast.net> (raw)
So our port causes a warning on failure of the types in question to be the same. This fixes it. Our CORE_ADDR is 64-bits, our ints are 32-bits.
Could someone shepherd it in?
diff --git a/gdb/symfile.c b/gdb/symfile.c
index f03fca7..e63a1c5 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -3613,7 +3613,7 @@ simple_read_overlay_table (void)
cache_novlys = read_memory_integer (BMSYMBOL_VALUE_ADDRESS (novlys_msym),
4, byte_order);
cache_ovly_table
- = (unsigned int (*)[4]) xmalloc (cache_novlys * sizeof (*cache_ovly_table));
+ = (CORE_ADDR (*)[4]) xmalloc (cache_novlys * sizeof (*cache_ovly_table));
cache_ovly_table_base = BMSYMBOL_VALUE_ADDRESS (ovly_table_msym);
read_target_long_array (cache_ovly_table_base,
(CORE_ADDR *) cache_ovly_table,
next reply other threads:[~2015-10-21 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 19:47 Mike Stump [this message]
2015-10-21 20:00 ` Simon Marchi
2015-10-22 9:59 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B2B5BD3D-8DF9-46EF-B3BF-4C2147528948@comcast.net \
--to=mikestump@comcast.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox