From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82198 invoked by alias); 21 Oct 2015 17:51:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82189 invoked by uid 89); 21 Oct 2015 17:51:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=no version=3.3.2 X-HELO: resqmta-po-04v.sys.comcast.net Received: from resqmta-po-04v.sys.comcast.net (HELO resqmta-po-04v.sys.comcast.net) (96.114.154.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 21 Oct 2015 17:51:43 +0000 Received: from resomta-po-20v.sys.comcast.net ([96.114.154.244]) by resqmta-po-04v.sys.comcast.net with comcast id XtrM1r0065Geu2801trifp; Wed, 21 Oct 2015 17:51:42 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-20v.sys.comcast.net with comcast id Xtrg1r00L2ztT3H01trhAr; Wed, 21 Oct 2015 17:51:42 +0000 From: Mike Stump Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: simple typo with cache_ovly_table Message-Id: Date: Wed, 21 Oct 2015 19:47:00 -0000 To: gdb-patches@sourceware.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-SW-Source: 2015-10/txt/msg00423.txt.bz2 So our port causes a warning on failure of the types in question to be the = same. This fixes it. Our CORE_ADDR is 64-bits, our ints are 32-bits. Could someone shepherd it in? diff --git a/gdb/symfile.c b/gdb/symfile.c index f03fca7..e63a1c5 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -3613,7 +3613,7 @@ simple_read_overlay_table (void) cache_novlys =3D read_memory_integer (BMSYMBOL_VALUE_ADDRESS (novlys_msym= ), 4, byte_order); cache_ovly_table - =3D (unsigned int (*)[4]) xmalloc (cache_novlys * sizeof (*cache_ovly_= table)); + =3D (CORE_ADDR (*)[4]) xmalloc (cache_novlys * sizeof (*cache_ovly_tab= le)); cache_ovly_table_base =3D BMSYMBOL_VALUE_ADDRESS (ovly_table_msym); read_target_long_array (cache_ovly_table_base, (CORE_ADDR *) cache_ovly_table,