RE: [PATCH V4 0/8] Intel(R) MPX register support

["Tedeschi, Walfred" <walfred.tedeschi@intel.com>]

Hi Eli,

Common code I meant the target dependent files, i.e. amd64-tdep.c and i386-tdep.c.

We added code to support Linux only. Linux registers are processed at amd64-tdep-linux.c and i386-tdep-linux.c as well as amd64-linux-nat.c and i386-linux-nat.c.

In order to implement the same features for windows we should have  modified the amd64-tdep-windows and i386-tdep-windows.c  and for Darwin amd64-tdep-darwin and i386-tdep-darwin.c for bsd there would be also some change on   amd64bsd-native.c and i386bsd-native.c. Additionally we OS support that is still not ready on the other platforms.

I hope to have clarified.

And again thanks a lot for your review,
-Fred

-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Eli Zaretskii
Sent: Monday, September 09, 2013 6:32 PM
To: Tedeschi, Walfred
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V4 0/8] Intel(R) MPX register support

> From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
> Date: Mon, 9 Sep 2013 11:28:28 +0000
> 
> We added first for GNU\Linux due to its importance.
> In order to support other target OSes the implementation has to be completely done; I assume there is very little to no common code between them.

I'm afraid I still don't understand.  Could you please identify the portions in the patch that are specific to GNU/Linux and will not work on other x86-based targets?  IOW, what "uncommon" code you had in mind above?

Thanks.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052