From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
Cc: walfred.tedeschi@intel.com, gdb-patches@sourceware.org
Subject: Re: [PATCH V4 0/8] Intel(R) MPX register support
Date: Wed, 25 Sep 2013 12:47:00 -0000 [thread overview]
Message-ID: <201309251247.r8PClZat006610@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <83eh8dgjxh.fsf@gnu.org> (message from Eli Zaretskii on Wed, 25 Sep 2013 15:33:30 +0300)
> Date: Wed, 25 Sep 2013 15:33:30 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
> > CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> > Date: Wed, 25 Sep 2013 11:51:23 +0000
> >
> > Common code I meant the target dependent files, i.e. amd64-tdep.c and i386-tdep.c.
> >
> > We added code to support Linux only. Linux registers are processed at amd64-tdep-linux.c and i386-tdep-linux.c as well as amd64-linux-nat.c and i386-linux-nat.c.
> >
> > In order to implement the same features for windows we should have modified the amd64-tdep-windows and i386-tdep-windows.c and for Darwin amd64-tdep-darwin and i386-tdep-darwin.c for bsd there would be also some change on amd64bsd-native.c and i386bsd-native.c. Additionally we OS support that is still not ready on the other platforms.
> >
> > I hope to have clarified.
>
> I'm sorry to insist, but that's exactly my question: why were the
> changes done in Linux-specific i386-tdep-linux.c etc., and not in the
> CPU-specific i386-tdep.c etc.? These registers are specific to a CPU,
> not to an OS, aren't they?
Most of the changes are in i386-tdep.c and amd64-tdep.c. The bits
that are in *-linux-tdep.c are the bits to support core dumps, which
are OS-specific. Although some of those core dump bits might be more
generally useful. That's hard to judge though as long as Linux is the
only OS that actually has the necessary interfaces for exposing these
registers to the debugger.
next prev parent reply other threads:[~2013-09-25 12:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 9:26 Walfred Tedeschi
2013-09-05 9:26 ` [PATCH V4 4/8] MPX for amd64 Walfred Tedeschi
2013-09-10 12:48 ` Mark Kettenis
2013-09-10 14:56 ` Walfred Tedeschi
2013-09-12 8:53 ` Tedeschi, Walfred
2013-09-05 9:26 ` [PATCH V4 3/8] Add MPX support for i386 Walfred Tedeschi
2013-09-05 9:40 ` Eli Zaretskii
2013-09-06 7:36 ` Tedeschi, Walfred
2013-09-05 9:26 ` [PATCH V4 7/8] Add MPX registers tests Walfred Tedeschi
2013-09-05 9:26 ` [PATCH V4 1/8] Fix conditions in creating a bitfield Walfred Tedeschi
2013-09-05 9:26 ` [PATCH V4 2/8] Add MPX registers XML files Walfred Tedeschi
2013-09-05 9:26 ` [PATCH V4 6/8] Add pretty-printer for MPX bnd registers Walfred Tedeschi
2013-09-05 9:26 ` [PATCH V4 8/8] Add MPX feature description to GDB manual Walfred Tedeschi
2013-09-05 9:37 ` Eli Zaretskii
2013-09-05 9:26 ` [PATCH V4 5/8] Add MPX support to gdbserver Walfred Tedeschi
2013-09-05 9:41 ` [PATCH V4 0/8] Intel(R) MPX register support Eli Zaretskii
[not found] ` <AC542571535E904D8E8ADAE745D60B191B18DB69@IRSMSX104.ger.corp.intel.com>
2013-09-09 16:32 ` Eli Zaretskii
2013-09-25 11:51 ` Tedeschi, Walfred
2013-09-25 12:33 ` Eli Zaretskii
2013-09-25 12:41 ` Tedeschi, Walfred
2013-09-25 15:37 ` Eli Zaretskii
2013-09-25 12:47 ` Mark Kettenis [this message]
2013-09-09 12:25 Walfred Tedeschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309251247.r8PClZat006610@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox