From: Ozkan Sezer <sezeroz@gmail.com>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: PING: [PATCH] properly check error return from socket() and accept() calls
Date: Thu, 27 May 2010 00:09:00 -0000 [thread overview]
Message-ID: <AANLkTine7K-RWCeSOceDRLWb9Q5SzBPWRBHb2n7RBugs@mail.gmail.com> (raw)
In-Reply-To: <m3k4sgjwhz.fsf@fleche.redhat.com>
On Fri, Apr 9, 2010 at 9:45 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Ozkan" == Ozkan Sezer <sezeroz@gmail.com> writes:
>
> Ozkan> PING.
>
> Ozkan> 2010-04-03 Ozkan Sezer <sezeroz@gmail.com>
> Ozkan> gdb/
> Ozkan> * ser-tcp.c (net_open): Check error return from socket() call by its
> Ozkan> equality to -1 not by it being negative.
> Ozkan> (net_close): Likewise.
> [...]
>
> It seems reasonable enough to me.
>
> Do you have a copyright assignment in place? TBH it isn't clear to me
> whether this patch requires one -- it is long enough, but I would say
> that there is really only one way to write this patch.
>
> Tom
>
Committed now. Thanks.
--
Ozkan
next prev parent reply other threads:[~2010-05-26 22:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 6:39 Ozkan Sezer
2010-04-09 18:45 ` Tom Tromey
2010-04-09 18:47 ` Ozkan Sezer
2010-04-09 21:29 ` Ozkan Sezer
2010-05-16 0:18 ` Ozkan Sezer
2010-05-26 17:05 ` Ozkan Sezer
2010-05-27 0:09 ` Ozkan Sezer [this message]
2010-05-27 16:03 ` Tom Tromey
2010-05-27 16:44 ` Ozkan Sezer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTine7K-RWCeSOceDRLWb9Q5SzBPWRBHb2n7RBugs@mail.gmail.com \
--to=sezeroz@gmail.com \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox