From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20983 invoked by alias); 26 May 2010 22:41:41 -0000 Received: (qmail 20973 invoked by uid 22791); 26 May 2010 22:41:40 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-ew0-f210.google.com (HELO mail-ew0-f210.google.com) (209.85.219.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 May 2010 22:41:35 +0000 Received: by ewy2 with SMTP id 2so960238ewy.16 for ; Wed, 26 May 2010 15:41:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.33.135 with SMTP id h7mr1827935ebd.56.1274913692358; Wed, 26 May 2010 15:41:32 -0700 (PDT) Received: by 10.213.8.201 with HTTP; Wed, 26 May 2010 15:41:32 -0700 (PDT) In-Reply-To: References: Date: Thu, 27 May 2010 00:09:00 -0000 Message-ID: Subject: Re: PING: [PATCH] properly check error return from socket() and accept() calls From: Ozkan Sezer To: tromey@redhat.com Cc: gdb-patches@sources.redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00620.txt.bz2 On Fri, Apr 9, 2010 at 9:45 PM, Tom Tromey wrote: >>>>>> "Ozkan" =3D=3D Ozkan Sezer writes: > > Ozkan> PING. > > Ozkan> 2010-04-03 =A0Ozkan Sezer =A0 > Ozkan> gdb/ > Ozkan> =A0* ser-tcp.c (net_open): Check error return from socket() call b= y its > Ozkan> =A0equality to -1 not by it being negative. > Ozkan> =A0(net_close): Likewise. > [...] > > It seems reasonable enough to me. > > Do you have a copyright assignment in place? =A0TBH it isn't clear to me > whether this patch requires one -- it is long enough, but I would say > that there is really only one way to write this patch. > > Tom > Committed now. Thanks. -- Ozkan