Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [doc RFA] Use of FIXME, TODO, etc. in new code is prohibited.
Date: Tue, 02 Nov 2010 17:06:00 -0000	[thread overview]
Message-ID: <AANLkTincpoPi9BrDXRCzbovTmNFwTaGV2OQ8B2rqa2BH@mail.gmail.com> (raw)
In-Reply-To: <201011021704.oA2H4gCc024129@glazunov.sibelius.xs4all.nl>

On Tue, Nov 2, 2010 at 10:04 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Tue,  2 Nov 2010 09:37:06 -0700 (PDT)
>> From: dje@google.com (Doug Evans)
>>
>> Ok to check in?
>
> I think this is absolutely silly.  If you really require all code to
> be perfect and 100% complete, you'll never make progress.  It is much
> better to make small incremental changes.  And if the author of such a
> change realizes some of its deficiencies and bothers to document them
> with a FIXME or a TODO, I consider that to be a good thing.

fwiw, I agree.
But I want to document what the rule(/convention) *is*, and the text
as written is my current understanding of it.

>> 2010-11-02  Doug Evans  <dje@google.com>
>>
>>       * gdbint.texinfo (Coding Standards): Use of FIXME, TODO, etc.
>>       in new code is prohibited.
>>
>> Index: gdbint.texinfo
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
>> retrieving revision 1.327
>> diff -u -p -r1.327 gdbint.texinfo
>> --- gdbint.texinfo    20 Oct 2010 22:53:36 -0000      1.327
>> +++ gdbint.texinfo    2 Nov 2010 16:34:03 -0000
>> @@ -5855,6 +5855,9 @@ than trying to fit them into the 20 char
>>  line, since either the comment or the code will inevitably get longer
>>  than will fit, and then somebody will have to move it anyhow.
>>
>> +The use of @code{FIXME} and all similar comments in new code is prohibited.
>> +The rule is to not write code that requires them.
>> +
>>  @subsection C Usage
>>
>>  @cindex C data types
>> @@ -5980,7 +5983,9 @@ They exist mainly for consistency with t
>>  @itemize @bullet
>>
>>  @item
>> -Use @code{FIXME} instead of @code{TODO}.
>> +The use of @code{TODO} is prohibited, as is @code{FIXME} and
>> +all similar comments.
>> +The rule is to not write code that requires them.
>>
>>  @end itemize
>>
>>
>


  reply	other threads:[~2010-11-02 17:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 16:37 Doug Evans
2010-11-02 17:04 ` Mark Kettenis
2010-11-02 17:06   ` Doug Evans [this message]
2010-11-02 18:49 ` Eli Zaretskii
2010-11-03  0:04 ` Stan Shebs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTincpoPi9BrDXRCzbovTmNFwTaGV2OQ8B2rqa2BH@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox