From: Stan Shebs <stan@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [doc RFA] Use of FIXME, TODO, etc. in new code is prohibited.
Date: Wed, 03 Nov 2010 00:04:00 -0000 [thread overview]
Message-ID: <4CD0A70A.6030306@codesourcery.com> (raw)
In-Reply-To: <20101102163706.300142461AE@ruffy.mtv.corp.google.com>
On 11/2/10 9:37 AM, Doug Evans wrote:
>
> +The use of @code{FIXME} and all similar comments in new code is prohibited.
> +The rule is to not write code that requires them.
I think there are a couple flavors of FIXME notes that we need to
distinguish.
The first is an obvious but easily-fixed limitation; fixed-size buffer,
not checking a return result, and the like. It seems good for software
quality that we make people fix those kinds of problems at submission time.
The other kind of FIXME is an enhancement idea that comes to mind while
working on a patch, but that is out of scope. Maybe you notice that a
routine could be shared between GDB and GDBserver, or that an argument
to a target vector method is now redundant. We have a rule discouraging
multi-change patches, and a volunteer's time might be insufficient for a
separate followon patch. In such a case we should record the idea
*somewhere* - major design changes might be wiki fodder, but the body of
the code seems like the right place for lesser worthwhile changes. We
could just recommend adding the note in running text, but a special
marker helps it stand out.
Stan
prev parent reply other threads:[~2010-11-03 0:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 16:37 Doug Evans
2010-11-02 17:04 ` Mark Kettenis
2010-11-02 17:06 ` Doug Evans
2010-11-02 18:49 ` Eli Zaretskii
2010-11-03 0:04 ` Stan Shebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD0A70A.6030306@codesourcery.com \
--to=stan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox