From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] [python] Implement stop_p for gdb.Breakpoint
Date: Fri, 11 Mar 2011 20:59:00 -0000 [thread overview]
Message-ID: <AANLkTinQ+5TnCBp_EzPsDiDKf_QPzUtqpn-=6EYw0+Bk@mail.gmail.com> (raw)
In-Reply-To: <m3r5ad5z8o.fsf@fleche.redhat.com>
On Fri, Mar 11, 2011 at 9:43 AM, Tom Tromey <tromey@redhat.com> wrote:
> Phil> +/* Function that is called when a Python condition is evaluated. */
> Phil> +char *stop_func = "stop";
>
> `static const'
Better, static const char stop_func[] = "stop";
Or static const char* const stop_func.
[Assuming the code that uses this doesn't cough, sigh.]
Plus blank line between function comment and definition please.
[Your very good at catching all other style issues ...]
+/* Helper function that overrides this Python object's
+ PyObject_GenericSetAttr to allow extra validation of the attribute
+ being set. */
+static int
+local_setattro (PyObject *self, PyObject *name, PyObject *v)
next prev parent reply other threads:[~2011-03-11 18:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 16:33 Phil Muldoon
2011-02-23 18:05 ` Eli Zaretskii
2011-02-24 7:02 ` Doug Evans
2011-02-24 9:50 ` Phil Muldoon
[not found] ` <AANLkTikXyH+zYkFRoUmihmDYj_nxU5648UnF5T9G-Wte@mail.gmail.com>
2011-02-28 21:19 ` Doug Evans
2011-03-07 16:43 ` Phil Muldoon
2011-03-07 20:52 ` Tom Tromey
2011-03-10 6:47 ` Doug Evans
2011-03-11 1:55 ` Tom Tromey
2011-03-11 11:59 ` Phil Muldoon
2011-03-11 18:27 ` Tom Tromey
2011-03-11 20:59 ` Doug Evans [this message]
2011-03-13 22:28 ` Phil Muldoon
2011-03-14 14:49 ` Tom Tromey
2011-03-14 17:56 ` Phil Muldoon
2011-03-14 20:01 ` Tom Tromey
2011-03-14 21:27 ` Eli Zaretskii
2011-03-11 18:36 ` Tom Tromey
2011-03-07 22:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinQ+5TnCBp_EzPsDiDKf_QPzUtqpn-=6EYw0+Bk@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox