From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19234 invoked by alias); 11 Mar 2011 18:27:46 -0000 Received: (qmail 19224 invoked by uid 22791); 11 Mar 2011 18:27:46 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 18:27:40 +0000 Received: from hpaq1.eem.corp.google.com (hpaq1.eem.corp.google.com [172.25.149.1]) by smtp-out.google.com with ESMTP id p2BIRbWS028094 for ; Fri, 11 Mar 2011 10:27:38 -0800 Received: from vxc34 (vxc34.prod.google.com [10.241.33.162]) by hpaq1.eem.corp.google.com with ESMTP id p2BIPYio032549 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 11 Mar 2011 10:27:36 -0800 Received: by vxc34 with SMTP id 34so3294817vxc.41 for ; Fri, 11 Mar 2011 10:27:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.190.131 with SMTP id di3mr2739017vcb.71.1299868055910; Fri, 11 Mar 2011 10:27:35 -0800 (PST) Received: by 10.220.193.135 with HTTP; Fri, 11 Mar 2011 10:27:35 -0800 (PST) In-Reply-To: References: Date: Fri, 11 Mar 2011 20:59:00 -0000 Message-ID: Subject: Re: [patch] [python] Implement stop_p for gdb.Breakpoint From: Doug Evans To: Tom Tromey Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00670.txt.bz2 On Fri, Mar 11, 2011 at 9:43 AM, Tom Tromey wrote: > Phil> +/* Function that is called when a Python condition is evaluated. = =A0*/ > Phil> +char *stop_func =3D "stop"; > > `static const' Better, static const char stop_func[] =3D "stop"; Or static const char* const stop_func. [Assuming the code that uses this doesn't cough, sigh.] Plus blank line between function comment and definition please. [Your very good at catching all other style issues ...] +/* Helper function that overrides this Python object's + PyObject_GenericSetAttr to allow extra validation of the attribute + being set. */ +static int +local_setattro (PyObject *self, PyObject *name, PyObject *v)