From: Hui Zhu <teawater@gmail.com>
To: Doug Evans <dje@google.com>, Stan Shebs <stan@codesourcery.com>,
Michael Snyder <msnyder@vmware.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] tracepoint: add new trace command "printf"[0] gdb
Date: Fri, 11 Feb 2011 03:49:00 -0000 [thread overview]
Message-ID: <AANLkTinEuZSGNt0=Sj4tZVzpuPoJHL+KdxyHeJOUN_Ot@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinOejC4S1cwA_uxdjWbpveLvR7C==mJMSSrw-aH@mail.gmail.com>
Hi all,
I sent the first version patch has been more than a month. And I have
done with the support in the KGTP for the support.
But I am still not get a code review or something. Are you reviewing
or have plan to review this patch?
Thanks,
Hui
On Fri, Feb 4, 2011 at 23:59, Hui Zhu <teawater@gmail.com> wrote:
> The prev version cannot support %s. So make a new version to support it.
>
> And I think current way to handle printf is too much hack way. Maybe
> I need find out a more better way to handle the printf.
>
> Thanks,
> Hui
>
> 2011-02-04 Hui Zhu <teawater@gmail.com>
>
> * ax-gdb.c (gen_printf_expr_callback): New function.
> * ax-general.c (ax_memcpy): New function.
> (aop_map): Add new entry for "printf".
> (ax_print): Handle "printf".
> (ax_reqs): Ditto.
> * ax.h (agent_op): Add aop_printf.
> (ax_memcpy): Forward declare.
> * printcmd.c (printf_callback): New typedef.
> (string_printf): New function from ui_printf.
> (ui_printf): Call string_printf.
> (printf_command): Remove static.
> * tracepoint.c (printf_command, gen_printf_expr_callback,
> printf_callback, string_printf): Forward declares.
> (validate_actionline, encode_actions_1): handle printf_command.
>
next prev parent reply other threads:[~2011-02-11 3:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 16:29 Hui Zhu
2011-01-03 19:21 ` Doug Evans
2011-01-04 4:34 ` Hui Zhu
2011-01-04 6:19 ` Doug Evans
2011-01-04 12:07 ` Hui Zhu
2011-01-05 17:24 ` Doug Evans
2011-01-05 18:18 ` Michael Snyder
2011-01-06 6:42 ` Hui Zhu
2011-01-05 20:51 ` Stan Shebs
2011-01-06 6:43 ` Hui Zhu
2011-01-28 5:54 ` Hui Zhu
2011-02-04 15:59 ` Hui Zhu
2011-02-11 3:49 ` Hui Zhu [this message]
2011-02-11 18:45 ` Tom Tromey
2011-02-17 8:16 ` Hui Zhu
2011-02-21 8:18 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinEuZSGNt0=Sj4tZVzpuPoJHL+KdxyHeJOUN_Ot@mail.gmail.com' \
--to=teawater@gmail.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox