From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78140-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6573 invoked by alias); 11 Feb 2011 03:49:49 -0000
Received: (qmail 6563 invoked by uid 22791); 11 Feb 2011 03:49:48 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-gw0-f41.google.com (HELO mail-gw0-f41.google.com) (74.125.83.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Feb 2011 03:49:37 +0000
Received: by gwj22 with SMTP id 22so992768gwj.0        for <gdb-patches@sourceware.org>; Thu, 10 Feb 2011 19:49:35 -0800 (PST)
Received: by 10.151.14.12 with SMTP id r12mr3326ybi.295.1297396175526; Thu, 10 Feb 2011 19:49:35 -0800 (PST)
MIME-Version: 1.0
Received: by 10.147.34.12 with HTTP; Thu, 10 Feb 2011 19:49:15 -0800 (PST)
In-Reply-To: <AANLkTinOejC4S1cwA_uxdjWbpveLvR7C==mJMSSrw-aH@mail.gmail.com>
References: <AANLkTimhMH+qUE1NmQ+f6+L8BcEU+k07eU+M9B-gLsrk@mail.gmail.com> <AANLkTik=K4Dk-Mkc5P7DDofzqwThhE6LvCM4rT-U_LNt@mail.gmail.com> <AANLkTiktJB=V0KS0u31rWMA6CyoV6J3+9Yufcgr=efr-@mail.gmail.com> <AANLkTinOj2JE8U=cu1ntVfh7nmTwnKDTox22da09vfyF@mail.gmail.com> <4D24D9DD.8090104@codesourcery.com> <AANLkTi=K3tw6_-uYDL8W4mSaL6nFPx-N541ALMC9-JZX@mail.gmail.com> <AANLkTik3mLyEUb4wRCbuG4X10=+Dp0_myYSC+kSjkzbL@mail.gmail.com> <AANLkTinOejC4S1cwA_uxdjWbpveLvR7C==mJMSSrw-aH@mail.gmail.com>
From: Hui Zhu <teawater@gmail.com>
Date: Fri, 11 Feb 2011 03:49:00 -0000
Message-ID: <AANLkTinEuZSGNt0=Sj4tZVzpuPoJHL+KdxyHeJOUN_Ot@mail.gmail.com>
Subject: Re: [PATCH] tracepoint: add new trace command "printf"[0] gdb
To: Doug Evans <dje@google.com>, Stan Shebs <stan@codesourcery.com>, 	Michael Snyder <msnyder@vmware.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00207.txt.bz2

Hi all,

I sent the first version patch has been more than a month.  And I have
done with the support in the KGTP for the support.

But I am still not get a code review or something.  Are you reviewing
or have plan to review this patch?

Thanks,
Hui

On Fri, Feb 4, 2011 at 23:59, Hui Zhu <teawater@gmail.com> wrote:
> The prev version cannot support %s. =A0So make a new version to support i=
t.
>
> And I think current way to handle printf is too much hack way. =A0Maybe
> I need find out a more better way to handle the printf.
>
> Thanks,
> Hui
>
> 2011-02-04 =A0Hui Zhu =A0<teawater@gmail.com>
>
> =A0 =A0 =A0 =A0* ax-gdb.c (gen_printf_expr_callback): New function.
> =A0 =A0 =A0 =A0* ax-general.c (ax_memcpy): New function.
> =A0 =A0 =A0 =A0(aop_map): Add new entry for "printf".
> =A0 =A0 =A0 =A0(ax_print): Handle "printf".
> =A0 =A0 =A0 =A0(ax_reqs): Ditto.
> =A0 =A0 =A0 =A0* ax.h (agent_op): Add aop_printf.
> =A0 =A0 =A0 =A0(ax_memcpy): Forward declare.
> =A0 =A0 =A0 =A0* printcmd.c (printf_callback): New typedef.
> =A0 =A0 =A0 =A0(string_printf): New function from ui_printf.
> =A0 =A0 =A0 =A0(ui_printf): Call string_printf.
> =A0 =A0 =A0 =A0(printf_command): Remove static.
> =A0 =A0 =A0 =A0* tracepoint.c (printf_command, gen_printf_expr_callback,
> =A0 =A0 =A0 =A0printf_callback, string_printf): Forward declares.
> =A0 =A0 =A0 =A0(validate_actionline, encode_actions_1): handle printf_com=
mand.
>