From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
Doug Evans <dje@google.com>
Subject: Re: [patch] Re: Advice on fixing gdb/12528
Date: Tue, 15 Mar 2011 19:12:00 -0000 [thread overview]
Message-ID: <AANLkTin7qeNsg5nGLQ44ybKpx492DW1UgjzH-Arqfqu-@mail.gmail.com> (raw)
In-Reply-To: <20110315183650.GA29330@host1.jankratochvil.net>
On Tue, Mar 15, 2011 at 11:36 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
>> PR gdb/12528
>> * gdb.dwarf2/break-on-linker-gcd-function.exp: New test.
>> * gdb.dwarf2/break-on-linker-gcd-function.cc: New file.
>
> It seems correct to me, please check it in.
Is location of the test case ok?
The same problem could well exist on non-dwarf platforms.
I also noticed that gdb.dwarf2/Makefile.in would need to have
break-on-linker-gcd-function added to EXECUTABLES (or the executable
renamed to break-on-linker-gcd-function.x).
>> +# This accepts e.g. "Breakpoint 1 at 0x40968a" (fixed GDB)
>> +# but rejects e.g. "Breakpoint 1 at 0x4" (broken GDB).
>> +gdb_test "b [gdb_get_line_number "gdb break here"]" "Breakpoint \[0-9\] at 0x\[0-9a-f\]\[0-9a-f\]+: .*"
>
> I was thinking if some prologue cannot be >=0x10 due to some alignments etc.
Perhaps "[$hex][$hex][$hex]+" to weed out up to 0xff ?
Thanks,
--
Paul Pluzhnikov
next prev parent reply other threads:[~2011-03-15 18:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 17:09 Paul Pluzhnikov
2011-03-11 18:27 ` Tom Tromey
2011-03-14 21:16 ` [patch] " Paul Pluzhnikov
2011-03-15 3:16 ` Jan Kratochvil
2011-03-15 5:26 ` Paul Pluzhnikov
2011-03-15 15:35 ` Tom Tromey
2011-03-15 15:45 ` Jan Kratochvil
2011-03-15 16:00 ` Paul Pluzhnikov
2011-03-15 18:50 ` Jan Kratochvil
2011-03-15 19:12 ` Paul Pluzhnikov [this message]
2011-03-15 19:18 ` Jan Kratochvil
2011-03-15 19:41 ` Paul Pluzhnikov
2011-03-15 23:26 ` Jan Kratochvil
2011-03-16 0:13 ` Paul Pluzhnikov
2011-03-16 8:20 ` Jan Kratochvil
2011-03-16 17:43 ` Paul Pluzhnikov
2011-03-16 17:52 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin7qeNsg5nGLQ44ybKpx492DW1UgjzH-Arqfqu-@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox