From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79696-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6445 invoked by alias); 15 Mar 2011 18:50:54 -0000
Received: (qmail 6436 invoked by uid 22791); 15 Mar 2011 18:50:53 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_XF,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 18:50:47 +0000
Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7])	by smtp-out.google.com with ESMTP id p2FIoi83012576	for <gdb-patches@sourceware.org>; Tue, 15 Mar 2011 11:50:44 -0700
Received: from vxc11 (vxc11.prod.google.com [10.241.33.139])	by hpaq7.eem.corp.google.com with ESMTP id p2FInxeV008141	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT)	for <gdb-patches@sourceware.org>; Tue, 15 Mar 2011 11:50:38 -0700
Received: by vxc11 with SMTP id 11so1133888vxc.23        for <gdb-patches@sourceware.org>; Tue, 15 Mar 2011 11:50:38 -0700 (PDT)
Received: by 10.52.72.67 with SMTP id b3mr1774863vdv.116.1300215037984; Tue, 15 Mar 2011 11:50:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.60.9 with HTTP; Tue, 15 Mar 2011 11:49:47 -0700 (PDT)
In-Reply-To: <20110315183650.GA29330@host1.jankratochvil.net>
References: <AANLkTim5vFBo4=mP7-83dqKbmuMAP3ThS6ZW_VN3rjg4@mail.gmail.com> <m3wrk560mf.fsf@fleche.redhat.com> <AANLkTin=U9bE2NoO4abS-qibKMsOCEj+-=G7k=OjXYXf@mail.gmail.com> <20110315004140.GA28560@host1.jankratochvil.net> <AANLkTimka58XAPbM45uv-DFKezKS5J-RTM-8mvBeaQMS@mail.gmail.com> <20110315183650.GA29330@host1.jankratochvil.net>
From: Paul Pluzhnikov <ppluzhnikov@google.com>
Date: Tue, 15 Mar 2011 19:12:00 -0000
Message-ID: <AANLkTin7qeNsg5nGLQ44ybKpx492DW1UgjzH-Arqfqu-@mail.gmail.com>
Subject: Re: [patch] Re: Advice on fixing gdb/12528
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>,        Doug Evans <dje@google.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00809.txt.bz2

On Tue, Mar 15, 2011 at 11:36 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:

>> =A0 =A0 =A0 =A0PR gdb/12528
>> =A0 =A0 =A0 =A0* gdb.dwarf2/break-on-linker-gcd-function.exp: New test.
>> =A0 =A0 =A0 =A0* gdb.dwarf2/break-on-linker-gcd-function.cc: New file.
>
> It seems correct to me, please check it in.

Is location of the test case ok?

The same problem could well exist on non-dwarf platforms.

I also noticed that gdb.dwarf2/Makefile.in would need to have
break-on-linker-gcd-function added to EXECUTABLES (or the executable
renamed to break-on-linker-gcd-function.x).

>> +# This accepts e.g. "Breakpoint 1 at 0x40968a" (fixed GDB)
>> +# but rejects e.g. "Breakpoint 1 at 0x4" (broken GDB).
>> +gdb_test "b [gdb_get_line_number "gdb break here"]" "Breakpoint \[0-9\]=
 at 0x\[0-9a-f\]\[0-9a-f\]+: .*"
>
> I was thinking if some prologue cannot be >=3D0x10 due to some alignments=
 etc.

Perhaps "[$hex][$hex][$hex]+" to weed out up to 0xff ?

Thanks,
--=20
Paul Pluzhnikov