From: Mike Frysinger <vapier@gentoo.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: add noreturn markings to more hw abort/halt funcs
Date: Mon, 10 Jan 2011 21:54:00 -0000 [thread overview]
Message-ID: <AANLkTin1SsCm0TLCs5UyGyV9k_LPevP7MrX7EpAEyRLM@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=ufCW0zgCmJ+gBAqT5O8y+aLJZjR1aG7HvfkJG@mail.gmail.com>
On Mon, Jan 10, 2011 at 1:00 PM, Doug Evans wrote:
> On Sat, Jan 8, 2011 at 6:14 PM, Mike Frysinger wrote:
>> These functions either call abort() themselves, or call functions which
>> are already marked noreturn. Either way, they don't return, so mark them
>> as such so calling code can assume this. This fixes some uninitialized
>> warnings due to code paths that end in an abort function.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>
>> 2010-01-08 Mike Frysinger <vapier@gentoo.org>
>>
>> * hw-device.h (hw_abort, hw_vabort, hw_halt): Add noreturn attribute.
>> * sim-hw.h (sim_hw_abort): Likewise.
>
> This is ok.
committed then, thanks !
-mike
prev parent reply other threads:[~2011-01-10 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 2:14 Mike Frysinger
2011-01-10 18:00 ` Doug Evans
2011-01-10 21:54 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin1SsCm0TLCs5UyGyV9k_LPevP7MrX7EpAEyRLM@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox