From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14933 invoked by alias); 10 Jan 2011 21:54:28 -0000 Received: (qmail 14920 invoked by uid 22791); 10 Jan 2011 21:54:27 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Jan 2011 21:54:21 +0000 Received: by fxm12 with SMTP id 12so12786823fxm.0 for ; Mon, 10 Jan 2011 13:54:19 -0800 (PST) Received: by 10.223.116.1 with SMTP id k1mr1284317faq.51.1294696448011; Mon, 10 Jan 2011 13:54:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.74.137 with HTTP; Mon, 10 Jan 2011 13:53:47 -0800 (PST) In-Reply-To: References: <1294539266-12692-1-git-send-email-vapier@gentoo.org> From: Mike Frysinger Date: Mon, 10 Jan 2011 21:54:00 -0000 Message-ID: Subject: Re: [PATCH] sim: add noreturn markings to more hw abort/halt funcs To: Doug Evans Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00205.txt.bz2 On Mon, Jan 10, 2011 at 1:00 PM, Doug Evans wrote: > On Sat, Jan 8, 2011 at 6:14 PM, Mike Frysinger wrote: >> These functions either call abort() themselves, or call functions which >> are already marked noreturn. =A0Either way, they don't return, so mark t= hem >> as such so calling code can assume this. =A0This fixes some uninitialized >> warnings due to code paths that end in an abort function. >> >> Signed-off-by: Mike Frysinger >> >> 2010-01-08 =A0Mike Frysinger =A0 >> >> =A0 =A0 =A0 =A0* hw-device.h (hw_abort, hw_vabort, hw_halt): Add noretur= n attribute. >> =A0 =A0 =A0 =A0* sim-hw.h (sim_hw_abort): Likewise. > > This is ok. committed then, thanks ! -mike