Re: [patch] Handle absent "/usr/sbin/" in prelink error output.

[Doug Evans <dje@google.com>]

On Tue, Nov 16, 2010 at 1:11 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> I'm seeing the following output from prelink:
>
> prelink: /g3/gnu/sourceware/pretty-printers/build/obj64/gdb/testsuite/gdb.base/attach-pie-misread.d/ld-linux-x86-64.so.2 does not have .gnu.prelink_undo section
>
> which causes attach-pie-misread.exp to fail with:
>
> FAIL: gdb.base/attach-pie-misread.exp: unprelink ld-linux-x86-64.so.2 pre-unprelink
>
> I will check in the following patch in two days if there are no objections.
>
> 2010-11-16  Doug Evans  <dje@google.com>
>
>        * lib/prelink-support.exp (prelink_no): Handle absent "/usr/sbin/"
>        in prelink error output.
>
> Index: lib/prelink-support.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/lib/prelink-support.exp,v
> retrieving revision 1.3
> diff -u -p -r1.3 prelink-support.exp
> --- lib/prelink-support.exp     12 Oct 2010 18:12:49 -0000      1.3
> +++ lib/prelink-support.exp     16 Nov 2010 21:06:58 -0000
> @@ -221,7 +221,7 @@ proc prelink_no {arg {name {}}} {
>     }
>     # Last line does miss the trailing \n.  There can be multiple such messages
>     # as ARG may list multiple files.
> -    if {$result == 1 && [regexp {^(/usr/sbin/prelink[^\r\n]*: [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} {
> +    if {$result == 1 && [regexp {^((/usr/sbin/)?prelink[^\r\n]*: [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} {
>        pass $test
>        return 1
>     } else {
>

Well, this shouldn't have caused a regression, but break-interp.exp
breaks badly with it.
So there's a deeper bug here.  Blech.