From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9387 invoked by alias); 16 Nov 2010 21:23:47 -0000 Received: (qmail 9299 invoked by uid 22791); 16 Nov 2010 21:23:46 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Nov 2010 21:23:40 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id oAGLNbHN020779 for ; Tue, 16 Nov 2010 13:23:37 -0800 Received: from pxi16 (pxi16.prod.google.com [10.243.27.16]) by wpaz21.hot.corp.google.com with ESMTP id oAGLMoTg003539 for ; Tue, 16 Nov 2010 13:23:36 -0800 Received: by pxi16 with SMTP id 16so400297pxi.32 for ; Tue, 16 Nov 2010 13:23:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.219.73 with SMTP id ht9mr7098320qcb.190.1289942615486; Tue, 16 Nov 2010 13:23:35 -0800 (PST) Received: by 10.220.185.203 with HTTP; Tue, 16 Nov 2010 13:23:35 -0800 (PST) In-Reply-To: <20101116211114.EAB2A2460AB@ruffy.mtv.corp.google.com> References: <20101116211114.EAB2A2460AB@ruffy.mtv.corp.google.com> Date: Tue, 16 Nov 2010 21:23:00 -0000 Message-ID: Subject: Re: [patch] Handle absent "/usr/sbin/" in prelink error output. From: Doug Evans To: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00214.txt.bz2 On Tue, Nov 16, 2010 at 1:11 PM, Doug Evans wrote: > Hi. > > I'm seeing the following output from prelink: > > prelink: /g3/gnu/sourceware/pretty-printers/build/obj64/gdb/testsuite/gdb= .base/attach-pie-misread.d/ld-linux-x86-64.so.2 does not have .gnu.prelink_= undo section > > which causes attach-pie-misread.exp to fail with: > > FAIL: gdb.base/attach-pie-misread.exp: unprelink ld-linux-x86-64.so.2 pre= -unprelink > > I will check in the following patch in two days if there are no objection= s. > > 2010-11-16 =A0Doug Evans =A0 > > =A0 =A0 =A0 =A0* lib/prelink-support.exp (prelink_no): Handle absent "/us= r/sbin/" > =A0 =A0 =A0 =A0in prelink error output. > > Index: lib/prelink-support.exp > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/testsuite/lib/prelink-support.exp,v > retrieving revision 1.3 > diff -u -p -r1.3 prelink-support.exp > --- lib/prelink-support.exp =A0 =A0 12 Oct 2010 18:12:49 -0000 =A0 =A0 = =A01.3 > +++ lib/prelink-support.exp =A0 =A0 16 Nov 2010 21:06:58 -0000 > @@ -221,7 +221,7 @@ proc prelink_no {arg {name {}}} { > =A0 =A0 } > =A0 =A0 # Last line does miss the trailing \n. =A0There can be multiple s= uch messages > =A0 =A0 # as ARG may list multiple files. > - =A0 =A0if {$result =3D=3D 1 && [regexp {^(/usr/sbin/prelink[^\r\n]*: [^= ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { > + =A0 =A0if {$result =3D=3D 1 && [regexp {^((/usr/sbin/)?prelink[^\r\n]*:= [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { > =A0 =A0 =A0 =A0pass $test > =A0 =A0 =A0 =A0return 1 > =A0 =A0 } else { > Well, this shouldn't have caused a regression, but break-interp.exp breaks badly with it. So there's a deeper bug here. Blech.