Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: bfin: fix thinko in SIC pin encoding
Date: Thu, 24 Mar 2011 03:14:00 -0000	[thread overview]
Message-ID: <AANLkTi=uyrRbyEP=HqZFuDM_eS9=2cpUrYHMK6ycoaDi@mail.gmail.com> (raw)
In-Reply-To: <1300857306-7437-1-git-send-email-vapier@gentoo.org>

On Wed, Mar 23, 2011 at 01:15, Mike Frysinger wrote:
> When encoding the SIC/pin info into unique input port ids, I used bases
> of 100 when I meant to use 0x100.  Rather than simply fix the decoding
> math in the different functions, create a few helper macros to simplify
> the SIC/pin encoding and decoding steps.  This makes the resulting tables
> nice & clear.

after looking over this a bit more, i realized that the clean up also
allowed for merging of the bf533/bf537 port event handlers.  so i did
that.

difference is reflected in:
    (bfin_sic_533_port_event): Delete.
    (bfin_sic_finish): Call set_hw_port_event with
    bfin_sic_537_port_event for BF533 and BF59x targets.
-mike


      reply	other threads:[~2011-03-24  3:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 11:09 Mike Frysinger
2011-03-24  3:14 ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=uyrRbyEP=HqZFuDM_eS9=2cpUrYHMK6ycoaDi@mail.gmail.com' \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    --cc=toolchain-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox