From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4423 invoked by alias); 24 Mar 2011 03:11:22 -0000 Received: (qmail 4414 invoked by uid 22791); 24 Mar 2011 03:11:21 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Mar 2011 03:11:16 +0000 Received: by fxm18 with SMTP id 18so9314818fxm.0 for ; Wed, 23 Mar 2011 20:11:15 -0700 (PDT) Received: by 10.223.97.1 with SMTP id j1mr304611fan.86.1300936275093; Wed, 23 Mar 2011 20:11:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.83.11 with HTTP; Wed, 23 Mar 2011 20:10:55 -0700 (PDT) In-Reply-To: <1300857306-7437-1-git-send-email-vapier@gentoo.org> References: <1300857306-7437-1-git-send-email-vapier@gentoo.org> From: Mike Frysinger Date: Thu, 24 Mar 2011 03:14:00 -0000 Message-ID: Subject: Re: [PATCH] sim: bfin: fix thinko in SIC pin encoding To: gdb-patches@sourceware.org Cc: toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01050.txt.bz2 On Wed, Mar 23, 2011 at 01:15, Mike Frysinger wrote: > When encoding the SIC/pin info into unique input port ids, I used bases > of 100 when I meant to use 0x100. =C2=A0Rather than simply fix the decodi= ng > math in the different functions, create a few helper macros to simplify > the SIC/pin encoding and decoding steps. =C2=A0This makes the resulting t= ables > nice & clear. after looking over this a bit more, i realized that the clean up also allowed for merging of the bf533/bf537 port event handlers. so i did that. difference is reflected in: (bfin_sic_533_port_event): Delete. (bfin_sic_finish): Call set_hw_port_event with bfin_sic_537_port_event for BF533 and BF59x targets. -mike