From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Subject: Re: [commit]: dw2_expand_symtabs_with_filename: ignore type units
Date: Wed, 08 Dec 2010 18:16:00 -0000 [thread overview]
Message-ID: <AANLkTi=AUrdkCfzNKq4_Rr-+XShyiJTfyomx0+Q1dpG0@mail.gmail.com> (raw)
In-Reply-To: <20101208181053.9444E2461AD@ruffy.mtv.corp.google.com>
On Wed, Dec 8, 2010 at 10:10 AM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> fyi, I checked this in.
>
> A supplemental patch is to rename expand_symtabs_with_filename.
> expand_code_symtabs_with_filename?
> Let me know if you want this change too.
>
> Btw, prior to this patch "break main" on one program here
> expanded gdb's memory usage by 2.5G. :-)
>
> 2010-12-08 Doug Evans <dje@google.com>
>
> * symfile.h (quick_symbol_functions): Clarify usage of
> expand_symtabs_with_filename.
> * dwarf2read.c (dw2_expand_symtabs_with_filename): Only iterate over
> comp units, not type units.
btw, for future reference,
TUs (DW_TAG_type_unit) can share line tables.
E.g. a program may have 95000 TUs but there may be only 5000 line
tables for all of them.
There may be more work that's needed here, and going forward we'll
want to support such sharing.
next prev parent reply other threads:[~2010-12-08 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 18:11 Doug Evans
2010-12-08 18:16 ` Doug Evans [this message]
2010-12-09 16:39 ` Tom Tromey
2010-12-14 4:03 ` Doug Evans
2010-12-09 8:29 ` Yao Qi
2010-12-09 15:43 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=AUrdkCfzNKq4_Rr-+XShyiJTfyomx0+Q1dpG0@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox