From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76846-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14096 invoked by alias); 8 Dec 2010 18:16:51 -0000
Received: (qmail 14083 invoked by uid 22791); 8 Dec 2010 18:16:50 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Dec 2010 18:16:40 +0000
Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93])	by smtp-out.google.com with ESMTP id oB8IGdWh024225	for <gdb-patches@sourceware.org>; Wed, 8 Dec 2010 10:16:39 -0800
Received: from gwb17 (gwb17.prod.google.com [10.200.2.17])	by wpaz29.hot.corp.google.com with ESMTP id oB8IEoSa023710	for <gdb-patches@sourceware.org>; Wed, 8 Dec 2010 10:16:38 -0800
Received: by gwb17 with SMTP id 17so1054495gwb.2        for <gdb-patches@sourceware.org>; Wed, 08 Dec 2010 10:16:37 -0800 (PST)
MIME-Version: 1.0
Received: by 10.90.50.4 with SMTP id x4mr12113294agx.90.1291832197786; Wed, 08 Dec 2010 10:16:37 -0800 (PST)
Received: by 10.90.81.2 with HTTP; Wed, 8 Dec 2010 10:16:37 -0800 (PST)
In-Reply-To: <20101208181053.9444E2461AD@ruffy.mtv.corp.google.com>
References: <20101208181053.9444E2461AD@ruffy.mtv.corp.google.com>
Date: Wed, 08 Dec 2010 18:16:00 -0000
Message-ID: <AANLkTi=AUrdkCfzNKq4_Rr-+XShyiJTfyomx0+Q1dpG0@mail.gmail.com>
Subject: Re: [commit]: dw2_expand_symtabs_with_filename: ignore type units
From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00091.txt.bz2

On Wed, Dec 8, 2010 at 10:10 AM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> fyi, I checked this in.
>
> A supplemental patch is to rename expand_symtabs_with_filename.
> expand_code_symtabs_with_filename?
> Let me know if you want this change too.
>
> Btw, prior to this patch "break main" on one program here
> expanded gdb's memory usage by 2.5G. =A0:-)
>
> 2010-12-08 =A0Doug Evans =A0<dje@google.com>
>
> =A0 =A0 =A0 =A0* symfile.h (quick_symbol_functions): Clarify usage of
> =A0 =A0 =A0 =A0expand_symtabs_with_filename.
> =A0 =A0 =A0 =A0* dwarf2read.c (dw2_expand_symtabs_with_filename): Only it=
erate over
> =A0 =A0 =A0 =A0comp units, not type units.

btw, for future reference,
TUs (DW_TAG_type_unit) can share line tables.
E.g. a program may have 95000 TUs but there may be only 5000 line
tables for all of them.
There may be more work that's needed here, and going forward we'll
want to support such sharing.