RE: [PATCH] gdbserver: Introduce write_error_msg

["Metzger, Markus T" <markus.t.metzger@intel.com>]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Wednesday, November 23, 2016 4:36 PM
> To: gdb-patches@sourceware.org
> Subject: [PATCH] gdbserver: Introduce write_error_msg
> 
> Instead of writing an error message to (gdbserver's) stderr and then
> returning back "E01" to GDB, send the error message to GDB directly
> using the E.MSG format, so the user can potentially see it.  Several
> places in the code already do this manually.  This patch adds a new
> function (write_error_msg) that abstracts out the "E." prefix detail.
> 
> gdb/gdbserver/ChangeLog:
> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
> 
> 	* remote-utils.c (write_error_msg): New function.
> 	* remote-utils.h (write_error_msg): Declare.
> 	* server.c (handle_btrace_general_set)
> 	(handle_btrace_conf_general_set, handle_general_set)
> 	(handle_qxfer_btrace, handle_qxfer_btrace_conf, resume)
> 	(handle_v_requests): Use write_error_msg.

The btrace bits look good to me.

Thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928