From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82993 invoked by alias); 23 Nov 2016 16:06:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82983 invoked by uid 89); 23 Nov 2016 16:06:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=nicole, Nicole, U*gdb-patches, gdbpatchessourcewareorg X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 16:06:04 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 23 Nov 2016 08:05:41 -0800 X-ExtLoop1: 1 Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 23 Nov 2016 08:05:39 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.52]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002; Wed, 23 Nov 2016 16:05:38 +0000 From: "Metzger, Markus T" To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdbserver: Introduce write_error_msg Date: Wed, 23 Nov 2016 16:06:00 -0000 Message-ID: References: <1479915352-23983-1-git-send-email-palves@redhat.com> In-Reply-To: <1479915352-23983-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00674.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Wednesday, November 23, 2016 4:36 PM > To: gdb-patches@sourceware.org > Subject: [PATCH] gdbserver: Introduce write_error_msg >=20 > Instead of writing an error message to (gdbserver's) stderr and then > returning back "E01" to GDB, send the error message to GDB directly > using the E.MSG format, so the user can potentially see it. Several > places in the code already do this manually. This patch adds a new > function (write_error_msg) that abstracts out the "E." prefix detail. >=20 > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Pedro Alves >=20 > * remote-utils.c (write_error_msg): New function. > * remote-utils.h (write_error_msg): Declare. > * server.c (handle_btrace_general_set) > (handle_btrace_conf_general_set, handle_general_set) > (handle_qxfer_btrace, handle_qxfer_btrace_conf, resume) > (handle_v_requests): Use write_error_msg. The btrace bits look good to me. Thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928