From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Mike Frysinger <vapier@gentoo.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "jan.kratochvil@redhat.com" <jan.kratochvil@redhat.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: RE: [PATCH 1/2] i386-cpuid: add support for identifying a processor
Date: Mon, 17 Feb 2014 08:04:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B230AA66925@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1912377.WkKB1rPacE@vapier>
> -----Original Message-----
> From: Mike Frysinger [mailto:vapier@gentoo.org]
> Sent: Friday, February 14, 2014 6:30 PM
> > +#else /* i386 && x86_64 */
> > +
> > +/* See i386-cpuid.h. */
> > +
> > +struct i386_cpu
> > +i386_this_cpu (void)
> > +{
> > + struct i386_cpu cpu;
> > +
> > + cpu.vendor = CV_UNKNOWN;
> > +
> > + return cpu;
> > +}
> > +
> > +#endif /* i386 && x86_64 */
>
>
> afaict, you don't need the #else. the non-x86 codepaths in i386-cpuid.h will
> set the return value to 0, and your main code will treat this as an error and
> set cpu.vendor to CV_UNKNOWN.
Thanks, you're right. That'll simplify it.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
prev parent reply other threads:[~2014-02-17 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 12:30 Markus Metzger
2014-02-13 12:30 ` [PATCH 2/2] btrace: use i386-cpuid's cpu identifier Markus Metzger
2014-02-13 13:29 ` [PATCH 1/2] i386-cpuid: add support for identifying a processor Mark Kettenis
2014-02-13 13:34 ` Metzger, Markus T
2014-02-13 18:32 ` Pedro Alves
2014-02-14 8:30 ` Metzger, Markus T
2014-02-14 17:29 ` Mike Frysinger
2014-02-17 8:04 ` Metzger, Markus T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B230AA66925@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox