From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10720 invoked by alias); 17 Feb 2014 08:04:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10709 invoked by uid 89); 17 Feb 2014 08:04:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2014 08:04:25 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 17 Feb 2014 00:04:23 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 17 Feb 2014 00:04:22 -0800 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 17 Feb 2014 08:03:51 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.244]) by IRSMSX105.ger.corp.intel.com ([169.254.7.202]) with mapi id 14.03.0123.003; Mon, 17 Feb 2014 08:03:51 +0000 From: "Metzger, Markus T" To: Mike Frysinger , "gdb-patches@sourceware.org" CC: "jan.kratochvil@redhat.com" , Mark Kettenis Subject: RE: [PATCH 1/2] i386-cpuid: add support for identifying a processor Date: Mon, 17 Feb 2014 08:04:00 -0000 Message-ID: References: <1392294615-16416-1-git-send-email-markus.t.metzger@intel.com> <1912377.WkKB1rPacE@vapier> In-Reply-To: <1912377.WkKB1rPacE@vapier> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00528.txt.bz2 > -----Original Message----- > From: Mike Frysinger [mailto:vapier@gentoo.org] > Sent: Friday, February 14, 2014 6:30 PM > > +#else /* i386 && x86_64 */ > > + > > +/* See i386-cpuid.h. */ > > + > > +struct i386_cpu > > +i386_this_cpu (void) > > +{ > > + struct i386_cpu cpu; > > + > > + cpu.vendor =3D CV_UNKNOWN; > > + > > + return cpu; > > +} > > + > > +#endif /* i386 && x86_64 */ >=20 >=20 > afaict, you don't need the #else. the non-x86 codepaths in i386-cpuid.h = will > set the return value to 0, and your main code will treat this as an error= and > set cpu.vendor to CV_UNKNOWN. Thanks, you're right. That'll simplify it. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052