From: Simon Marchi <simark@simark.ca>
To: Luis Machado <luis.machado@linaro.org>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/arm: avoid undefined behavior shift when decoding immediate value
Date: Sat, 14 Nov 2020 11:20:45 -0500 [thread overview]
Message-ID: <9faaaa24-18c5-5040-e2a5-2116b6a7a48d@simark.ca> (raw)
In-Reply-To: <f85a4456-d588-66f3-1b63-acd126da034e@linaro.org>
On 2020-11-13 5:35 p.m., Luis Machado via Gdb-patches wrote:
>> +public:
>> + /* Read a 4 bytes instruction bytes from memory using the BYTE_ORDER
> The comment above reads a bit funny.
Oh, thanks for spotting that, I fixed it.
Simon
prev parent reply other threads:[~2020-11-14 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 20:49 Simon Marchi via Gdb-patches
2020-11-11 10:00 ` Alan Hayward via Gdb-patches
2020-11-11 20:44 ` Simon Marchi via Gdb-patches
2020-11-13 17:05 ` Simon Marchi
2020-11-13 22:35 ` Luis Machado via Gdb-patches
2020-11-14 16:20 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9faaaa24-18c5-5040-e2a5-2116b6a7a48d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox