From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pNLxB+EDsF/vIQAAWB0awg (envelope-from ) for ; Sat, 14 Nov 2020 11:20:49 -0500 Received: by simark.ca (Postfix, from userid 112) id 129401F08B; Sat, 14 Nov 2020 11:20:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C06201E552 for ; Sat, 14 Nov 2020 11:20:48 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 30140385781B; Sat, 14 Nov 2020 16:20:48 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BF246385781B for ; Sat, 14 Nov 2020 16:20:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF246385781B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3A87B1E552; Sat, 14 Nov 2020 11:20:45 -0500 (EST) Subject: Re: [PATCH] gdb/arm: avoid undefined behavior shift when decoding immediate value To: Luis Machado , Simon Marchi , gdb-patches@sourceware.org References: <20201109204945.1313866-1-simon.marchi@efficios.com> From: Simon Marchi Message-ID: <9faaaa24-18c5-5040-e2a5-2116b6a7a48d@simark.ca> Date: Sat, 14 Nov 2020 11:20:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-13 5:35 p.m., Luis Machado via Gdb-patches wrote: >> +public: >> + /* Read a 4 bytes instruction bytes from memory using the BYTE_ORDER > The comment above reads a bit funny. Oh, thanks for spotting that, I fixed it. Simon