Re: [PATCH] Add two new warnings to warning.m4

[Tom de Vries <tdevries@suse.de>]

On 6/5/26 9:38 AM, Tom de Vries wrote:
> On 6/3/26 9:05 PM, Tom Tromey wrote:
>> I recently learned that GCC has improved -Wdangling-reference and
>> added -Wunterminated-string-initialization.  Both of these seem
>> sensible to me, so this patch adds them to warning.m4.
>>
> 
> This looks fine to me.
> 
> I did wonder whether we should add __attribute__((nonstring)) to 
> gdb_byte, but atm it doesn't seem necessary.
> 

Ah, I just read that the attribute doesn't apply to types, so nm.

Thanks,
- Tom

> Reviewed-By: Tom de Vries <tdevries@suse.de>
> 
> Thanks,
> - Tom
> 
>> gdb rebuilds cleanly with this in place on x86-64 Fedora 43.
>> ---
>>   gdb/configure         | 2 ++
>>   gdbserver/configure   | 2 ++
>>   gdbsupport/configure  | 2 ++
>>   gdbsupport/warning.m4 | 2 ++
>>   4 files changed, 8 insertions(+)
>>
>> diff --git a/gdb/configure b/gdb/configure
>> index 17c95930f60..80931d10bef 100755
>> --- a/gdb/configure
>> +++ b/gdb/configure
>> @@ -31580,6 +31580,7 @@ fi
>>   # The options we'll try to enable.
>>   build_warnings=" \
>>   -Wall \
>> +-Wdangling-reference \
>>   -Wdeprecated-copy \
>>   -Wdeprecated-copy-dtor \
>>   -Wduplicated-cond \
>> @@ -31597,6 +31598,7 @@ build_warnings=" \
>>   -Wshadow=local \
>>   -Wstrict-null-sentinel \
>>   -Wsuggest-override \
>> +-Wunterminated-string-initialization \
>>   -Wunused-but-set-parameter \
>>   -Wunused-but-set-variable \
>>   -Wunused-const-variable=1 \
>> diff --git a/gdbserver/configure b/gdbserver/configure
>> index 0159da6bdf4..46faecc3a20 100755
>> --- a/gdbserver/configure
>> +++ b/gdbserver/configure
>> @@ -13448,6 +13448,7 @@ fi
>>   # The options we'll try to enable.
>>   build_warnings=" \
>>   -Wall \
>> +-Wdangling-reference \
>>   -Wdeprecated-copy \
>>   -Wdeprecated-copy-dtor \
>>   -Wduplicated-cond \
>> @@ -13465,6 +13466,7 @@ build_warnings=" \
>>   -Wshadow=local \
>>   -Wstrict-null-sentinel \
>>   -Wsuggest-override \
>> +-Wunterminated-string-initialization \
>>   -Wunused-but-set-parameter \
>>   -Wunused-but-set-variable \
>>   -Wunused-const-variable=1 \
>> diff --git a/gdbsupport/configure b/gdbsupport/configure
>> index 584a80ef825..0bc9ff1db9a 100755
>> --- a/gdbsupport/configure
>> +++ b/gdbsupport/configure
>> @@ -14123,6 +14123,7 @@ fi
>>   # The options we'll try to enable.
>>   build_warnings=" \
>>   -Wall \
>> +-Wdangling-reference \
>>   -Wdeprecated-copy \
>>   -Wdeprecated-copy-dtor \
>>   -Wduplicated-cond \
>> @@ -14140,6 +14141,7 @@ build_warnings=" \
>>   -Wshadow=local \
>>   -Wstrict-null-sentinel \
>>   -Wsuggest-override \
>> +-Wunterminated-string-initialization \
>>   -Wunused-but-set-parameter \
>>   -Wunused-but-set-variable \
>>   -Wunused-const-variable=1 \
>> diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4
>> index 718ac34aa3c..3148feb740a 100644
>> --- a/gdbsupport/warning.m4
>> +++ b/gdbsupport/warning.m4
>> @@ -38,6 +38,7 @@ fi
>>   # The options we'll try to enable.
>>   build_warnings=" \
>>   -Wall \
>> +-Wdangling-reference \
>>   -Wdeprecated-copy \
>>   -Wdeprecated-copy-dtor \
>>   -Wduplicated-cond \
>> @@ -55,6 +56,7 @@ build_warnings=" \
>>   -Wshadow=local \
>>   -Wstrict-null-sentinel \
>>   -Wsuggest-override \
>> +-Wunterminated-string-initialization \
>>   -Wunused-but-set-parameter \
>>   -Wunused-but-set-variable \
>>   -Wunused-const-variable=1 \
>>
>> base-commit: 663cb9c0428068165fc98675599442163d302d41
>