From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id R9hQGcl9ImoqqTUAWB0awg (envelope-from ) for ; Fri, 05 Jun 2026 03:42:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f3wenb6F; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X9sOro6T; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f3wenb6F; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X9sOro6T; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 536951E024; Fri, 05 Jun 2026 03:42:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D3F81E024 for ; Fri, 05 Jun 2026 03:42:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E59074BCA43B for ; Fri, 5 Jun 2026 07:41:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E59074BCA43B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f3wenb6F; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X9sOro6T; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f3wenb6F; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X9sOro6T Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 0CF774BA799F for ; Fri, 5 Jun 2026 07:41:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CF774BA799F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CF774BA799F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780645292; cv=none; b=eMINMqsqIBMv/88ZDGd3+dAqUjEtMYvCeWN+dY0fkXg47OvATKUFZW34cKeCxkgjZMVZdTLmj0w3/eN9A6MKZx9CY/nkCWPS628Qgkfzr7z+V3xZmgsqE4Ro+uLCutwKx5h7z3rMp43GmsajtHorfo3kmbRdEAW1eG5Igq1crxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780645292; c=relaxed/simple; bh=b1CeG8pd/48w6/9XHc6V1cXyPjwIaG7niIHCfi79KqU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=jEmNvxeidofktXiiqQqCJoVdzVwdsfcoS+SsSTOrFKp2xZMuI0143u6Uki/8WhjFYfvzOpJIpq1GO+CCoUG7cNklaUbKxi4VLdA86locCn9aLcL0vfntvX0A1SF/Tld+ALH8TAZ+kRBCa71SaeNMRJJJpM3ijRsxq0+zeB3dyao= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f3wenb6F; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X9sOro6T; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f3wenb6F; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X9sOro6T DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CF774BA799F Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 07ADF6B100; Fri, 5 Jun 2026 07:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780645291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1SKIOt5DtbhSd5eEJnP/o8Wro4FCuxKNaJ8zUuwrnI=; b=f3wenb6F+43NqX60ityV2sa34GLewSQF0bPB3lZ+rMuNs5HoqM0BplVgBuQ00cFWEqwH9o /IaTT4elY4O87btQEOozzbD1R/Rlroq2tuZl9ttVrsqXjZtFxtDy514NjGU8AfZhGzsPwG iCq2BktciZ4UhUOW11CSRKvQdQohmTk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780645291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1SKIOt5DtbhSd5eEJnP/o8Wro4FCuxKNaJ8zUuwrnI=; b=X9sOro6T06UcPfiyyLuvbYTJXVfsTFMTK0sbfb0lBDI7Bs7w2+1kf09OiagjnRulwZKSTs WjS/Bv2F6prx9wBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=f3wenb6F; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=X9sOro6T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780645291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1SKIOt5DtbhSd5eEJnP/o8Wro4FCuxKNaJ8zUuwrnI=; b=f3wenb6F+43NqX60ityV2sa34GLewSQF0bPB3lZ+rMuNs5HoqM0BplVgBuQ00cFWEqwH9o /IaTT4elY4O87btQEOozzbD1R/Rlroq2tuZl9ttVrsqXjZtFxtDy514NjGU8AfZhGzsPwG iCq2BktciZ4UhUOW11CSRKvQdQohmTk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780645291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1SKIOt5DtbhSd5eEJnP/o8Wro4FCuxKNaJ8zUuwrnI=; b=X9sOro6T06UcPfiyyLuvbYTJXVfsTFMTK0sbfb0lBDI7Bs7w2+1kf09OiagjnRulwZKSTs WjS/Bv2F6prx9wBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E68D2779A8; Fri, 5 Jun 2026 07:41:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id L4QCN6p9ImrAPgAAD6G6ig (envelope-from ); Fri, 05 Jun 2026 07:41:30 +0000 Message-ID: <9ef1b39b-fff8-470d-b4ed-b2ed636611ec@suse.de> Date: Fri, 5 Jun 2026 09:41:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add two new warnings to warning.m4 From: Tom de Vries To: Tom Tromey , gdb-patches@sourceware.org References: <20260603190514.333176-1-tromey@adacore.com> <0ece6746-72f3-4827-b472-0ad2c9823f1c@suse.de> Content-Language: en-US In-Reply-To: <0ece6746-72f3-4827-b472-0ad2c9823f1c@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 07ADF6B100 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:email, suse.de:mid, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/5/26 9:38 AM, Tom de Vries wrote: > On 6/3/26 9:05 PM, Tom Tromey wrote: >> I recently learned that GCC has improved -Wdangling-reference and >> added -Wunterminated-string-initialization.  Both of these seem >> sensible to me, so this patch adds them to warning.m4. >> > > This looks fine to me. > > I did wonder whether we should add __attribute__((nonstring)) to > gdb_byte, but atm it doesn't seem necessary. > Ah, I just read that the attribute doesn't apply to types, so nm. Thanks, - Tom > Reviewed-By: Tom de Vries > > Thanks, > - Tom > >> gdb rebuilds cleanly with this in place on x86-64 Fedora 43. >> --- >>   gdb/configure         | 2 ++ >>   gdbserver/configure   | 2 ++ >>   gdbsupport/configure  | 2 ++ >>   gdbsupport/warning.m4 | 2 ++ >>   4 files changed, 8 insertions(+) >> >> diff --git a/gdb/configure b/gdb/configure >> index 17c95930f60..80931d10bef 100755 >> --- a/gdb/configure >> +++ b/gdb/configure >> @@ -31580,6 +31580,7 @@ fi >>   # The options we'll try to enable. >>   build_warnings=" \ >>   -Wall \ >> +-Wdangling-reference \ >>   -Wdeprecated-copy \ >>   -Wdeprecated-copy-dtor \ >>   -Wduplicated-cond \ >> @@ -31597,6 +31598,7 @@ build_warnings=" \ >>   -Wshadow=local \ >>   -Wstrict-null-sentinel \ >>   -Wsuggest-override \ >> +-Wunterminated-string-initialization \ >>   -Wunused-but-set-parameter \ >>   -Wunused-but-set-variable \ >>   -Wunused-const-variable=1 \ >> diff --git a/gdbserver/configure b/gdbserver/configure >> index 0159da6bdf4..46faecc3a20 100755 >> --- a/gdbserver/configure >> +++ b/gdbserver/configure >> @@ -13448,6 +13448,7 @@ fi >>   # The options we'll try to enable. >>   build_warnings=" \ >>   -Wall \ >> +-Wdangling-reference \ >>   -Wdeprecated-copy \ >>   -Wdeprecated-copy-dtor \ >>   -Wduplicated-cond \ >> @@ -13465,6 +13466,7 @@ build_warnings=" \ >>   -Wshadow=local \ >>   -Wstrict-null-sentinel \ >>   -Wsuggest-override \ >> +-Wunterminated-string-initialization \ >>   -Wunused-but-set-parameter \ >>   -Wunused-but-set-variable \ >>   -Wunused-const-variable=1 \ >> diff --git a/gdbsupport/configure b/gdbsupport/configure >> index 584a80ef825..0bc9ff1db9a 100755 >> --- a/gdbsupport/configure >> +++ b/gdbsupport/configure >> @@ -14123,6 +14123,7 @@ fi >>   # The options we'll try to enable. >>   build_warnings=" \ >>   -Wall \ >> +-Wdangling-reference \ >>   -Wdeprecated-copy \ >>   -Wdeprecated-copy-dtor \ >>   -Wduplicated-cond \ >> @@ -14140,6 +14141,7 @@ build_warnings=" \ >>   -Wshadow=local \ >>   -Wstrict-null-sentinel \ >>   -Wsuggest-override \ >> +-Wunterminated-string-initialization \ >>   -Wunused-but-set-parameter \ >>   -Wunused-but-set-variable \ >>   -Wunused-const-variable=1 \ >> diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4 >> index 718ac34aa3c..3148feb740a 100644 >> --- a/gdbsupport/warning.m4 >> +++ b/gdbsupport/warning.m4 >> @@ -38,6 +38,7 @@ fi >>   # The options we'll try to enable. >>   build_warnings=" \ >>   -Wall \ >> +-Wdangling-reference \ >>   -Wdeprecated-copy \ >>   -Wdeprecated-copy-dtor \ >>   -Wduplicated-cond \ >> @@ -55,6 +56,7 @@ build_warnings=" \ >>   -Wshadow=local \ >>   -Wstrict-null-sentinel \ >>   -Wsuggest-override \ >> +-Wunterminated-string-initialization \ >>   -Wunused-but-set-parameter \ >>   -Wunused-but-set-variable \ >>   -Wunused-const-variable=1 \ >> >> base-commit: 663cb9c0428068165fc98675599442163d302d41 >