From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix the i386 build
Date: Thu, 1 Oct 2020 19:13:35 -0400 [thread overview]
Message-ID: <9ee7ba55-65b3-acb5-27ab-6c38f07aa51b@simark.ca> (raw)
In-Reply-To: <20201001230538.16533-1-n54@gmx.com>
On 2020-10-01 7:05 p.m., Kamil Rytarowski wrote:
> Remove old, no longer needed and no longer valid extern.
>
> ../../gdb/i386-nbsd-tdep.c:58:12: error: 'i386nbsd_sc_reg_offset' was declared 'extern' and later 'static' [-fpermissive]
> 58 | static int i386nbsd_sc_reg_offset[] =
> | ^~~~~~~~~~~~~~~~~~~~~~
> In file included from ../../gdb/i386-nbsd-tdep.c:31:
> ../../gdb/i386-tdep.h:480:12: note: previous declaration of 'i386nbsd_sc_reg_offset'
> 480 | extern int i386nbsd_sc_reg_offset[];
> | ^~~~~~~~~~~~~~~~~~~~~~
This looks like an obvious patch to me.
Simon
prev parent reply other threads:[~2020-10-01 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 23:05 Kamil Rytarowski
2020-10-01 23:13 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ee7ba55-65b3-acb5-27ab-6c38f07aa51b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox