From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iH4lGKNidl+zGgAAWB0awg (envelope-from ) for ; Thu, 01 Oct 2020 19:13:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 540A91EDF4; Thu, 1 Oct 2020 19:13:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C06651E965 for ; Thu, 1 Oct 2020 19:13:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C5BD398B84C; Thu, 1 Oct 2020 23:13:38 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8679E3857C5B for ; Thu, 1 Oct 2020 23:13:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8679E3857C5B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2370E1E965; Thu, 1 Oct 2020 19:13:36 -0400 (EDT) Subject: Re: [PATCH] Fix the i386 build To: Kamil Rytarowski , gdb-patches@sourceware.org References: <20201001230538.16533-1-n54@gmx.com> From: Simon Marchi Message-ID: <9ee7ba55-65b3-acb5-27ab-6c38f07aa51b@simark.ca> Date: Thu, 1 Oct 2020 19:13:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201001230538.16533-1-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-10-01 7:05 p.m., Kamil Rytarowski wrote: > Remove old, no longer needed and no longer valid extern. > > ../../gdb/i386-nbsd-tdep.c:58:12: error: 'i386nbsd_sc_reg_offset' was declared 'extern' and later 'static' [-fpermissive] > 58 | static int i386nbsd_sc_reg_offset[] = > | ^~~~~~~~~~~~~~~~~~~~~~ > In file included from ../../gdb/i386-nbsd-tdep.c:31: > ../../gdb/i386-tdep.h:480:12: note: previous declaration of 'i386nbsd_sc_reg_offset' > 480 | extern int i386nbsd_sc_reg_offset[]; > | ^~~~~~~~~~~~~~~~~~~~~~ This looks like an obvious patch to me. Simon