Re: [PATCH 0/5] [pre-commit] Some pre-commit improvements

[Tom de Vries <tdevries@suse.de>]

On 8/13/26 7:26 AM, Tom de Vries wrote:
> On 8/12/26 8:16 PM, Simon Marchi wrote:
>> On 7/20/26 8:50 AM, Tom de Vries wrote:
>>> This patch series contains some pre-commit improvements.
>>>
>>> The third patch fixes the problem that flake8 is not run for gdb/gdb- 
>>> gdb.py.in.
>>>
>>> The first and second patch fix flake8 problems in gdb/gdb-gdb.py.in.
>>>
>>> The fourth and fifth patch makes pre-commit rely less on types 
>>> filtering,
>>> fixing PR build/34411.
>>>
>>> Tested on x86_64-linux.
>>>
>>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34411
>>>
>>> Tom de Vries (5):
>>>    [gdb] Fix bare except in gdb/gdb-gdb.py.in
>>>    [gdb] Remove superfluous global in gdb/gdb-gdb.py.in
>>>    [pre-commit] Run flake8 for gdb/gdb-gdb.py.in
>>>    [pre-commit] Don't require text type for check-whitespace hook
>>>    [pre-commit] Don't require text type for codespell hook
>>
>> FYI, I think that patches 1 and 2 are no longer necessary, because the
>> code has changed.
> 
> Indeed, thanks for pointing that out.
> 
> I've now submitted an alternative to patch 3.
> 

I've now pushed that one.

> Patches 4 and 5 still make sense, but both don't apply cleanly without 
> patch 3.  So I'll wait what happens with the alternative to decide how 
> to proceed.
> 

I've updated and pushed these two as well.

Thanks,
- Tom