From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0WC4DCuQjWqrFj8AWB0awg (envelope-from ) for ; Tue, 25 Aug 2026 08:52:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e4KbnFJO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n4Q8IINd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kQ6Obd74; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2mQ0efej; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2937A1E0A3; Tue, 25 Aug 2026 08:52:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8DD1B1E033 for ; Tue, 25 Aug 2026 08:52:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5789F4BA7994 for ; Tue, 25 Aug 2026 12:52:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5789F4BA7994 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e4KbnFJO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n4Q8IINd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kQ6Obd74; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2mQ0efej Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id D74644BA23CB for ; Tue, 25 Aug 2026 12:52:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D74644BA23CB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D74644BA23CB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787662353; cv=none; b=Xfx0HyEO/arZqwQL0Gf5C28qtONwbHrjC0oCP61GgsqR8le5IJn9PLETJctpvyHkhNvFNPgues4G3REpd8xv+fHMj4ygqAQHri7kqWYbwqwIculYZ74lTXWGp2KUZdkOkVKfG0PpkYe5QFUQfafIQR/Rfygg2H/thptzvDiUtBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787662353; c=relaxed/simple; bh=MFMnF6eQKVtgv0HlVWlxP4UMQ4qDP/fPkPu4dUuXyDM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=KTThzqUgSLxwcdsVCvPkl5fCWWuWUM66fV48IlejFq98ppcRhIQXNIhBG3oazw/A/MIXIN0jZWBEEWQLUsMyFN+ZJdkC9ggV8Cng88aiX4qEZS1K9nFdX0WvQ/u3uWBGX4pUsQ6D5ek1aRA08kF8tGyOarNIA5UIXDteanmyVt0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e4KbnFJO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n4Q8IINd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kQ6Obd74; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2mQ0efej DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D74644BA23CB Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7F2F786EF3; Tue, 25 Aug 2026 12:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787662347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KpZRJ5ttXSn2yelBaLeaPNQS8n+jibSvmH2Df1Tgzuc=; b=e4KbnFJOhhxqPzO4h/JkkwQnTlC+V2VtY5ODYO8Ug3kiB9t424IwyT04clcGbnby7N4N+Q UoCvHgAXBbk25LFuHYQUEZDGqzXADejaapeVPodCbiFHuUzqdt68Ad0ZcFlv6tG+ksVdwH jeoUcrAG0WNzq49yJEGiUpjjMEIFmrw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787662347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KpZRJ5ttXSn2yelBaLeaPNQS8n+jibSvmH2Df1Tgzuc=; b=n4Q8IINdjO2qkfSwVslZ9RVpDtybxzgHFYBX2l76VtMaYEI1+QNmgKzjrnysKnhstRs0IK lDf0d7ypUSSeQ+CQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787662343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KpZRJ5ttXSn2yelBaLeaPNQS8n+jibSvmH2Df1Tgzuc=; b=kQ6Obd74RXxRiIjrSvcRHkfoBSRWEE43ARLoc2rVwcIn7lSc5N/dtqFMCTfx3i5TLzFY+c Aqs925wCMttsOcfi/WnhZPKxX/0iOxAG2fx3wRj4iBz0Ga2S4FWlzJ0Idfrn04m8ndb+GK LmmBsmdEMVy20fZXPEQhDRD3JsZh3k0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787662343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KpZRJ5ttXSn2yelBaLeaPNQS8n+jibSvmH2Df1Tgzuc=; b=2mQ0efejoS7q4iu/560Nn9XdJzSnEAbePsk7ivp8HsswsbVuIXOWz7UBu74WcmhCj0SSCc 8V0/DQs/1MrcMbAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6B68113332; Tue, 25 Aug 2026 12:52:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8I4CGQeQjWqBFAAAD6G6ig (envelope-from ); Tue, 25 Aug 2026 12:52:23 +0000 Message-ID: <9e75aade-2be3-4cf0-9fa8-7650ce3b9085@suse.de> Date: Tue, 25 Aug 2026 14:52:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] [pre-commit] Some pre-commit improvements From: Tom de Vries To: Simon Marchi , gdb-patches@sourceware.org References: <20260720125056.1373177-1-tdevries@suse.de> <25438c2e-fccb-4c2c-8077-a383e4e1a051@simark.ca> <13e7e583-9314-4c8e-b599-ee9f6a502eae@suse.de> Content-Language: en-US In-Reply-To: <13e7e583-9314-4c8e-b599-ee9f6a502eae@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url, py.in:url, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/13/26 7:26 AM, Tom de Vries wrote: > On 8/12/26 8:16 PM, Simon Marchi wrote: >> On 7/20/26 8:50 AM, Tom de Vries wrote: >>> This patch series contains some pre-commit improvements. >>> >>> The third patch fixes the problem that flake8 is not run for gdb/gdb- >>> gdb.py.in. >>> >>> The first and second patch fix flake8 problems in gdb/gdb-gdb.py.in. >>> >>> The fourth and fifth patch makes pre-commit rely less on types >>> filtering, >>> fixing PR build/34411. >>> >>> Tested on x86_64-linux. >>> >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34411 >>> >>> Tom de Vries (5): >>>    [gdb] Fix bare except in gdb/gdb-gdb.py.in >>>    [gdb] Remove superfluous global in gdb/gdb-gdb.py.in >>>    [pre-commit] Run flake8 for gdb/gdb-gdb.py.in >>>    [pre-commit] Don't require text type for check-whitespace hook >>>    [pre-commit] Don't require text type for codespell hook >> >> FYI, I think that patches 1 and 2 are no longer necessary, because the >> code has changed. > > Indeed, thanks for pointing that out. > > I've now submitted an alternative to patch 3. > I've now pushed that one. > Patches 4 and 5 still make sense, but both don't apply cleanly without > patch 3.  So I'll wait what happens with the alternative to decide how > to proceed. > I've updated and pushed these two as well. Thanks, - Tom