Re: [PATCH] Add "set debug minsyms" command

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2018-12-24 15:51, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> It was indeed missing from the original patch, but I ended up 
> not
> Simon> adding a new command, so I don't think this is needed.
> 
> The manual documents the values for "set debug symtab-create".  I think
> a patch is indeed needed since you added a new value.

Actually that value is already used and documented:

Turns on or off display of debugging messages related to symbol table 
creation. The default is 0 (off). A value of 1 provides basic 
information. A value greater than 1 provides more verbose information.

> Also I was wondering why not just use "maint print msymbols".

Because I didn't know about it :).  Do you think the new debugging 
output is redundant and should be removed?  It's the same data (minimal 
symbols), but in a different order.  With "set debug symtab-create", 
they are shown in the order they are provided by the symbol reader (same 
order as in the file usually), whereas "maint print msymbols" shows them 
as saved in GDB's memory, sorted by address.  I think that the "set 
debug symtab-create" may be useful when debugging the symbol reader, 
whereas "maint print msymbols" may be useful when debugging lookups.

Simon