From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33127 invoked by alias); 26 Dec 2018 16:43:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33088 invoked by uid 89); 26 Dec 2018 16:43:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=greater, H*UA:Webmail, H*Ad:U*jhb, documents X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Dec 2018 16:43:26 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wBQGhKPP013290 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Dec 2018 11:43:24 -0500 Received: by simark.ca (Postfix, from userid 112) id 2936D1E7B1; Wed, 26 Dec 2018 11:43:20 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E5BDF1E059; Wed, 26 Dec 2018 11:43:18 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 26 Dec 2018 16:43:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Eli Zaretskii , jhb@freebsd.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Add "set debug minsyms" command In-Reply-To: <878t0er6l6.fsf@tromey.com> References: <20181221214706.26981-1-simon.marchi@ericsson.com> <18230036-5562-b705-a9b5-b9e435d63c32@FreeBSD.org> <798386c1-43f5-862e-1ee4-6e439ccf3133@FreeBSD.org> <3cdee7b5cded932a4e49c4e612ff6fcf@polymtl.ca> <83ftuqaukt.fsf@gnu.org> <7bb19b711cccb214d678e65b9383c4e5@polymtl.ca> <878t0er6l6.fsf@tromey.com> Message-ID: <9e2735708c805257c37485fbc2f451a8@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00334.txt.bz2 On 2018-12-24 15:51, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> It was indeed missing from the original patch, but I ended up > not > Simon> adding a new command, so I don't think this is needed. > > The manual documents the values for "set debug symtab-create". I think > a patch is indeed needed since you added a new value. Actually that value is already used and documented: Turns on or off display of debugging messages related to symbol table creation. The default is 0 (off). A value of 1 provides basic information. A value greater than 1 provides more verbose information. > Also I was wondering why not just use "maint print msymbols". Because I didn't know about it :). Do you think the new debugging output is redundant and should be removed? It's the same data (minimal symbols), but in a different order. With "set debug symtab-create", they are shown in the order they are provided by the symbol reader (same order as in the file usually), whereas "maint print msymbols" shows them as saved in GDB's memory, sorted by address. I think that the "set debug symtab-create" may be useful when debugging the symbol reader, whereas "maint print msymbols" may be useful when debugging lookups. Simon