From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/5] Further cleanup/modernization of gdb.base/commands.exp
Date: Wed, 09 Nov 2016 16:25:00 -0000 [thread overview]
Message-ID: <9d7681f17b6ab79976fdc9e3ae18632c@polymtl.ca> (raw)
In-Reply-To: <835da2d0-1d1a-907d-420e-5332f3336a9b@redhat.com>
On 2016-11-09 11:16, Pedro Alves wrote:
> On 11/09/2016 04:09 PM, Simon Marchi wrote:
>> On 2016-11-09 10:59, Pedro Alves wrote:
>>> And I'm wondering whether this below as well would be a good idea,
>>> or whether it'd obfuscate? If a good idea, maybe we'd put the new
>>> variable in gdb.exp.
>>
>> ...
>>
>>> @@ -45,7 +50,7 @@ proc_with_prefix gdbvar_simple_if_test {} {
>>> "else" \
>>> " p/x 0xdeadbeef" \
>>> "end"] \
>>> - "\\\$\[0-9\]* = 0xdeadbeef" \
>>> + "$valnum_re = 0xdeadbeef" \
>>> "#1"
>>
>>
>> That's not bad. I was going to suggest using {} instead of "" to get
>> rid of most backslashes (untested):
>>
>> -"\\\$\[0-9\]* = 0xdeadbeef"
>> +{\$[0-9]* = 0xdeadbeef}
>>
>> but with the variable it looks good as well.
>>
>
> Here's the resulting squashed patch then. WDYT?
LGTM.
next prev parent reply other threads:[~2016-11-09 16:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 0:19 [PATCH v2 0/5] Support an "unlimited" number of user-defined arguments Pedro Alves
2016-11-09 0:19 ` [PATCH v2 3/5] Fix PR 20559 - "eval" command and $arg0...$arg9/$argc substitution Pedro Alves
2016-11-09 0:19 ` [PATCH v2 2/5] Further cleanup/modernization of gdb.base/commands.exp Pedro Alves
2016-11-09 3:02 ` Simon Marchi
2016-11-09 15:56 ` Pedro Alves
2016-11-09 15:59 ` Pedro Alves
2016-11-09 16:09 ` Simon Marchi
2016-11-09 16:16 ` Pedro Alves
2016-11-09 16:25 ` Simon Marchi [this message]
2016-11-09 18:51 ` Pedro Alves
2016-11-09 16:22 ` Pedro Alves
2016-11-09 16:37 ` Pedro Alves
2016-11-09 16:41 ` Pedro Alves
2016-11-09 0:19 ` [PATCH v2 1/5] gdb/testsuite: Introduce "proc_with_prefix" Pedro Alves
2016-11-09 1:56 ` Simon Marchi
2016-11-09 3:10 ` [PATCH] Make gdb.mi/user-selected-context-sync.exp use proc_with_prefix Simon Marchi
2016-11-09 15:15 ` Pedro Alves
2016-11-09 15:57 ` Simon Marchi
2016-11-09 11:50 ` [PATCH v2 1/5] gdb/testsuite: Introduce "proc_with_prefix" Yao Qi
2016-11-09 0:25 ` [PATCH v2 5/5] Support an "unlimited" number of user-defined arguments Pedro Alves
2016-11-09 0:26 ` [PATCH v2 4/5] Test user-defined gdb commands and arguments stack Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d7681f17b6ab79976fdc9e3ae18632c@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox