From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-134688-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 116575 invoked by alias); 9 Nov 2016 16:25:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 116546 invoked by uid 89); 9 Nov 2016 16:25:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Nov 2016 16:24:59 +0000
Received: by simark.ca (Postfix, from userid 33)	id 9EC811E809; Wed,  9 Nov 2016 11:24:57 -0500 (EST)
To: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH v2 2/5] Further cleanup/modernization of  gdb.base/commands.exp
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 09 Nov 2016 16:25:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <835da2d0-1d1a-907d-420e-5332f3336a9b@redhat.com>
References: <1478650771-24430-1-git-send-email-palves@redhat.com> <1478650771-24430-3-git-send-email-palves@redhat.com> <994221f0964b21175ece863b9e4eed59@polymtl.ca> <1e856161-24c0-5f93-7847-a2bf9af57e8c@redhat.com> <c018dbb5-5aeb-8e90-38a9-f4c7aa29d39f@redhat.com> <937642fa3965d4029b5c98cb84a26954@polymtl.ca> <835da2d0-1d1a-907d-420e-5332f3336a9b@redhat.com>
Message-ID: <9d7681f17b6ab79976fdc9e3ae18632c@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.2
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg00228.txt.bz2

On 2016-11-09 11:16, Pedro Alves wrote:
> On 11/09/2016 04:09 PM, Simon Marchi wrote:
>> On 2016-11-09 10:59, Pedro Alves wrote:
>>> And I'm wondering whether this below as well would be a good idea,
>>> or whether it'd obfuscate?  If a good idea, maybe we'd put the new
>>> variable in gdb.exp.
>> 
>> ...
>> 
>>> @@ -45,7 +50,7 @@ proc_with_prefix gdbvar_simple_if_test {} {
>>>           "else" \
>>>           "  p/x 0xdeadbeef" \
>>>           "end"] \
>>> -    "\\\$\[0-9\]* = 0xdeadbeef" \
>>> +    "$valnum_re = 0xdeadbeef" \
>>>      "#1"
>> 
>> 
>> That's not bad.  I was going to suggest using {} instead of "" to get
>> rid of most backslashes (untested):
>> 
>> -"\\\$\[0-9\]* = 0xdeadbeef"
>> +{\$[0-9]* = 0xdeadbeef}
>> 
>> but with the variable it looks good as well.
>> 
> 
> Here's the resulting squashed patch then.  WDYT?

LGTM.