From: Pedro Alves <palves@redhat.com>
To: Alan Hayward <alan.hayward@arm.com>, gdb-patches@sourceware.org
Cc: nd@arm.com, Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] Testsuite: Remove race condition from mi-cmd-param-changed.exp
Date: Tue, 09 Oct 2018 13:00:00 -0000 [thread overview]
Message-ID: <9ca9ae00-ad0a-b0e2-9263-01693d8d872c@redhat.com> (raw)
In-Reply-To: <20181009124457.81037-1-alan.hayward@arm.com>
On 10/09/2018 01:44 PM, Alan Hayward wrote:
> target_supports_scheduler_locking does not wait for the gdb
> prompt after calling gdb_start_cmd.
>
> Fix by replacing with runto_main.
>
> This removes the racy behaviour of mi-cmd-param-changed.exp.
>
> gdb/testsuite/ChangeLog:
>
> 2018-10-09 Alan Hayward <alan.hayward@arm.com>
>
> * lib/gdb.exp (target_supports_scheduler_locking): Call runto_main.
Tom de Vries had already submitted a patch for this, but it
hadn't been reviewed yet. I've approved Tom's now. Sorry
about the duplicated work.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-10-09 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 12:45 Alan Hayward
2018-10-09 13:00 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca9ae00-ad0a-b0e2-9263-01693d8d872c@redhat.com \
--to=palves@redhat.com \
--cc=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox