From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69928 invoked by alias); 9 Oct 2018 13:00:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69644 invoked by uid 89); 9 Oct 2018 13:00:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:641, Tom's, Toms, tom's X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Oct 2018 13:00:25 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E2740811A7; Tue, 9 Oct 2018 13:00:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D870D10027CE; Tue, 9 Oct 2018 13:00:10 +0000 (UTC) Subject: Re: [PATCH] Testsuite: Remove race condition from mi-cmd-param-changed.exp To: Alan Hayward , gdb-patches@sourceware.org References: <20181009124457.81037-1-alan.hayward@arm.com> Cc: nd@arm.com, Tom de Vries From: Pedro Alves Message-ID: <9ca9ae00-ad0a-b0e2-9263-01693d8d872c@redhat.com> Date: Tue, 09 Oct 2018 13:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181009124457.81037-1-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00208.txt.bz2 On 10/09/2018 01:44 PM, Alan Hayward wrote: > target_supports_scheduler_locking does not wait for the gdb > prompt after calling gdb_start_cmd. > > Fix by replacing with runto_main. > > This removes the racy behaviour of mi-cmd-param-changed.exp. > > gdb/testsuite/ChangeLog: > > 2018-10-09 Alan Hayward > > * lib/gdb.exp (target_supports_scheduler_locking): Call runto_main. Tom de Vries had already submitted a patch for this, but it hadn't been reviewed yet. I've approved Tom's now. Sorry about the duplicated work. Thanks, Pedro Alves