Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Remove cleanup in get_return_value
Date: Fri, 28 Apr 2017 15:05:00 -0000	[thread overview]
Message-ID: <9bb1d6c4-b770-8075-eb80-f9cb0d90f253@redhat.com> (raw)
In-Reply-To: <1493389594-24434-5-git-send-email-yao.qi@linaro.org>

On 04/28/2017 03:26 PM, Yao Qi wrote:
> With regcache ctor, we can use it to create local object in
> get_return_value (), so that the cleanup can be removed.

LGTM.

Thanks,
Pedro Alves


  reply	other threads:[~2017-04-28 15:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 20:28 [PATCH 0/6] Class-fy regcache in GDB Yao Qi
2017-04-25 20:28 ` [PATCH 4/6] Simplify regcache_dup Yao Qi
2017-04-25 20:28 ` [PATCH 6/6] Remove cleanup in get_return_value Yao Qi
2017-04-25 20:28 ` [PATCH 1/6 OBV] Change readonly_p to bool Yao Qi
2017-04-25 20:28 ` [PATCH 2/6] Add constructor and destructor to regcache Yao Qi
2017-04-27 17:34   ` Pedro Alves
2017-04-28 13:42     ` Yao Qi
2017-04-25 20:29 ` [PATCH 5/6] Use copy ctor in regcache_dup Yao Qi
2017-04-27 17:37   ` Pedro Alves
2017-04-28  9:11     ` Yao Qi
2017-04-28  9:51       ` Pedro Alves
2017-04-28 13:20         ` Yao Qi
2017-04-25 20:29 ` [PATCH 3/6] Class-fy regcache Yao Qi
2017-04-27 17:35   ` Pedro Alves
2017-04-28 14:26 ` [PATCH 0/4 v2] Class-fy regcache in GDB Yao Qi
2017-04-28 14:26   ` [PATCH 4/4] Remove cleanup in get_return_value Yao Qi
2017-04-28 15:05     ` Pedro Alves [this message]
2017-04-28 14:26   ` [PATCH 2/4] Simplify regcache_dup Yao Qi
2017-04-28 15:03     ` Pedro Alves
2017-04-28 14:26   ` [PATCH 3/4] Use tag dispatch regcache ctor in regcache_dup Yao Qi
2017-04-28 15:04     ` Pedro Alves
2017-04-28 14:26   ` [PATCH 1/4] Class-fy regcache Yao Qi
2017-04-28 15:03     ` Pedro Alves
2017-04-28 21:44       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bb1d6c4-b770-8075-eb80-f9cb0d90f253@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox