Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/6 OBV] Change readonly_p to bool
Date: Tue, 25 Apr 2017 20:28:00 -0000	[thread overview]
Message-ID: <1493152106-3246-2-git-send-email-yao.qi@linaro.org> (raw)
In-Reply-To: <1493152106-3246-1-git-send-email-yao.qi@linaro.org>

This patch changes readonly_p type to bool.  It is obvious, and I'll push
it in.

gdb:

2017-04-25  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (struct regcache) <readonly_p>: Change its type
	to bool.
	(regcache_xmalloc_1): Update parameter type and callers update.
---
 gdb/regcache.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/regcache.c b/gdb/regcache.c
index 41c23a5..966f0c7 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -209,7 +209,7 @@ struct regcache
      cache can only be updated via the methods regcache_dup() and
      regcache_cpy().  The actual contents are determined by the
      reggroup_save and reggroup_restore methods.  */
-  int readonly_p;
+  bool readonly_p;
   /* If this is a read-write cache, which thread's registers is
      it connected to?  */
   ptid_t ptid;
@@ -227,7 +227,7 @@ regcache_get_ptid (const struct regcache *regcache)
 
 static struct regcache *
 regcache_xmalloc_1 (struct gdbarch *gdbarch, struct address_space *aspace,
-		    int readonly_p)
+		    bool readonly_p)
 {
   struct regcache_descr *descr;
   struct regcache *regcache;
@@ -259,7 +259,7 @@ regcache_xmalloc_1 (struct gdbarch *gdbarch, struct address_space *aspace,
 struct regcache *
 regcache_xmalloc (struct gdbarch *gdbarch, struct address_space *aspace)
 {
-  return regcache_xmalloc_1 (gdbarch, aspace, 1);
+  return regcache_xmalloc_1 (gdbarch, aspace, true);
 }
 
 void
@@ -507,7 +507,7 @@ get_thread_arch_aspace_regcache (ptid_t ptid, struct gdbarch *gdbarch,
 	&& get_regcache_arch (list->regcache) == gdbarch)
       return list->regcache;
 
-  new_regcache = regcache_xmalloc_1 (gdbarch, aspace, 0);
+  new_regcache = regcache_xmalloc_1 (gdbarch, aspace, false);
   new_regcache->ptid = ptid;
 
   list = XNEW (struct regcache_list);
-- 
1.9.1


  parent reply	other threads:[~2017-04-25 20:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 20:28 [PATCH 0/6] Class-fy regcache in GDB Yao Qi
2017-04-25 20:28 ` [PATCH 4/6] Simplify regcache_dup Yao Qi
2017-04-25 20:28 ` Yao Qi [this message]
2017-04-25 20:28 ` [PATCH 6/6] Remove cleanup in get_return_value Yao Qi
2017-04-25 20:28 ` [PATCH 2/6] Add constructor and destructor to regcache Yao Qi
2017-04-27 17:34   ` Pedro Alves
2017-04-28 13:42     ` Yao Qi
2017-04-25 20:29 ` [PATCH 5/6] Use copy ctor in regcache_dup Yao Qi
2017-04-27 17:37   ` Pedro Alves
2017-04-28  9:11     ` Yao Qi
2017-04-28  9:51       ` Pedro Alves
2017-04-28 13:20         ` Yao Qi
2017-04-25 20:29 ` [PATCH 3/6] Class-fy regcache Yao Qi
2017-04-27 17:35   ` Pedro Alves
2017-04-28 14:26 ` [PATCH 0/4 v2] Class-fy regcache in GDB Yao Qi
2017-04-28 14:26   ` [PATCH 4/4] Remove cleanup in get_return_value Yao Qi
2017-04-28 15:05     ` Pedro Alves
2017-04-28 14:26   ` [PATCH 2/4] Simplify regcache_dup Yao Qi
2017-04-28 15:03     ` Pedro Alves
2017-04-28 14:26   ` [PATCH 3/4] Use tag dispatch regcache ctor in regcache_dup Yao Qi
2017-04-28 15:04     ` Pedro Alves
2017-04-28 14:26   ` [PATCH 1/4] Class-fy regcache Yao Qi
2017-04-28 15:03     ` Pedro Alves
2017-04-28 21:44       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493152106-3246-2-git-send-email-yao.qi@linaro.org \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox