Re: [PATCH] Replace contribution list in CONTRIBUTE file with wiki link

[Simon Marchi <simon.marchi@ericsson.com>]

On 2019-01-23 4:46 a.m., Alan Hayward wrote:
> The GDB wiki page has a much better contribution checklist than
> that in the GDB CONTRIBUTE file.  In addition, the wiki is easier
> to keep up to date with current processes.
> 
> Reduce the CONTRIBUTE file down to two short paragraphs with links
> to both the contribution process and the GDB homepage.  This also
> ensures anyone reading the CONTRIBUTE file for a given release has
> access to the latest processes.
> 
> gdb/ChangeLog:
> 
> 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
> 
> 	* CONTRIBUTE: Replace contribution list with wiki link.
> ---
>  gdb/CONTRIBUTE | 147 +++++--------------------------------------------
>  1 file changed, 14 insertions(+), 133 deletions(-)
> 
> diff --git a/gdb/CONTRIBUTE b/gdb/CONTRIBUTE
> index 30f51ccdc7..e9a96e59bf 100644
> --- a/gdb/CONTRIBUTE
> +++ b/gdb/CONTRIBUTE
> @@ -4,142 +4,23 @@
>  GDB is a collaborative project and one which wants to encourage new
>  development.  You may wish to fix GDB bugs, improve testing, port GDB
>  to a new platform, update documentation, add new GDB features, and the
> -like. To help with this, there is a lot of documentation
> -available.. In addition to the user guide and internals manual
> -included in the GDB distribution, the GDB web pages also contain much
> -information.
> +like.  To help with this, there is a lot of documentation available.
> +In addition to the user guide and internals manual included in the GDB
> +distribution, the GDB web pages also contain much information.
>  
>  You may also want to submit your change so that can be considered for
> -conclusion in a future version of GDB (see below).  Regardless, we
> -encourage you to distribute the change yourself.
> +conclusion in a future version of GDB.  For a full guide on how to
> +submit patches see:

Is it just me, or the "You may also..." sentence is very weird?  conclusion
or inclusion?  There seems to be a missing work after "so that".

Otherwise, this LGTM, thanks.

Simon